Bug 28651

Summary:	Cannot receive files using gabble 0.9
Product:	Telepathy	Reporter:	Daniele E. Domenichelli <daniele.domenichelli>
Component:	tp-qt	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	daniele.domenichelli
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Fixes the file transfer receiver example

Description Daniele E. Domenichelli 2010-06-21 10:21:41 UTC

Telepathy-qt4 cannot receive files using gabble 0.9.12 and 0.9.13.

When trying to send a file, the sender receives a "contact doesn't have file transfer capabilities" error and doesn't even try to open the file transfer channel with the receiver.

I tested both with the example and with a Tp::AbstractClientHandler that can accept FileTransfer channel.

After downgrading to gabble 0.8.12, file transfer works again with both tests.

Comment 1 Daniele E. Domenichelli 2010-07-21 02:18:02 UTC

I was able to register capabilities using a Tp::AbstractClientHandler, I was missing TargetHandleType.
This is the working .client file:

---

[org.freedesktop.Telepathy.Client]
Interfaces=org.freedesktop.Telepathy.Client.Handler;

[org.freedesktop.Telepathy.Client.Handler.HandlerChannelFilter 0]
org.freedesktop.Telepathy.Channel.ChannelType s=org.freedesktop.Telepathy.Channel.Type.FileTransfer
org.freedesktop.Telepathy.Channel.Requested b=false
org.freedesktop.Telepathy.Channel.TargetHandleType u=1

---

The example in telepathy-qt4 doesn't use any handler and doesn't register anything, it just listens for every new incoming channel. Therefore mc doesn't export file transfer capabilities to other contacts and their clients cannot initiate a file transfer. Probably the example is outdated should be replaced by a new one using a Tp::AbstractClientHandler.

Comment 2 Daniele E. Domenichelli 2010-07-22 06:22:05 UTC

Created attachment 37304 [details] [review]
Fixes the file transfer receiver example

Using http://telepathy.freedesktop.org/spec/Connection_Interface_Contact_Capabilities.html#org.freedesktop.Telepathy.Connection.Interface.ContactCapabilities.UpdateCapabilities it is possible to advertise support for file transfer, without being a handler.

This patch fixes the example.

Comment 3 Andre Moreira Magalhaes 2010-07-22 14:45:38 UTC

Merged upstream with slightly modifications. It will be in next release 0.3.8.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.