Bug 28752

Summary:	Demos broken with i915g (and others?) since the new pipeline setup
Product:	Mesa	Reporter:	Chia-I Wu <olvaffe>
Component:	Other	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	keithw
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	work around an invalid write

Description Chia-I Wu 2010-06-25 01:35:24 UTC

Most demos are either blank or segfault after running a few seconds since

  commit b85a361ccbac956d2842251395c048a4b3f4c440
  Author: Keith Whitwell <keithw@vmware.com>
  Date:   Mon Jun 14 15:11:59 2010 +0100

      draw wip

with i915g (but not softpipe).  This includes glxgears.

From a quick look, the commit is not supposed to affect the pipe drivers.  What's more weird is that i915g is affected but softpipe is not.

The commit does not compile.  I needs to use the next next commit, a192b5eeafae80f9f9e7e7e442abc5b44d583d1a.

Comment 1 Chia-I Wu 2010-06-25 03:54:42 UTC

Created attachment 36488 [details] [review]
work around an invalid write

This seems to work around the bug I saw.

Comment 2 Zack Rusin 2010-06-25 06:42:00 UTC

Review of attachment 36488 [details] [review]:

Good catch. Yea, the sse runner is not great. We might need to force GALLIUM_NOSSE=1 as default soon. Please commit.

Comment 3 Chia-I Wu 2010-06-25 08:21:08 UTC

Thanks for review.  Patch committed as 7a9246c5d72290ed8455a426801b85b54374e102.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.