| Summary: | Check result of nice_address_set_from_string() ? | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Will Thompson <will> |
| Component: | gabble | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | youness.alaoui |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Will Thompson
2010-07-16 08:11:26 UTC
The tests don't seem to fail any more dramatically than they already do in master. I haven't fixed one issue it threw up: content_new_remote_candidates_cb in gtalk-file-collection.c doesn't check nice_address_set_from_string() and skip the candidate if it failed. I'm not sure whether this is okay and libnice will reject the candidate itself later, or whether we'll all die. Yes please to the branch. (In reply to comment #1) > content_new_remote_candidates_cb in gtalk-file-collection.c doesn't check > nice_address_set_from_string() and skip the candidate if it failed. I'm not > sure whether this is okay and libnice will reject the candidate itself later, > or whether we'll all die. I don't feel qualified to comment on this; let's see what Youness thinks. Merged the branch; retitling for the outstanding question. Humm.. good question, I think we'll all die. I checked and libnice doesn't check if the address is valid, I suppose it should. i'll fix libnice to check if the address received is valid or not. In the meantime, I suggest gabble to get fixed too, better be more robust and validate in gabble rather than later on. (In reply to comment #4) > Humm.. good question, I think we'll all die. I checked and libnice doesn't > check if the address is valid, I suppose it should. i'll fix libnice to check > if the address received is valid or not. In the meantime, I suggest gabble to > get fixed too, better be more robust and validate in gabble rather than later > on. bug 29143. Merged a fix for this bug to Gabble! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.