Bug 29163

Summary:	[glsl2] glean/shaderAPI fail
Product:	Mesa	Reporter:	Gordon Jin <gordon.jin>
Component:	Mesa core	Assignee:	mesa-dev
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	git
Hardware:	All
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	29044

Description Gordon Jin 2010-07-19 23:21:01 UTC

glean case shaderAPI fails with mesa glsl2 branch (17a307d154489d718ab51a6272d2054868d782f6 on July 16th), while passes with mesa master branch. 
Tested on Piketon.

error:
glean/tshaderapi.cpp:349 assertion "size == 1" failed
glean/tshaderapi.cpp:349 assertion "size == 1" failed
glean/tshaderapi.cpp:402 expected invalid operation but received no error
glean: shader/ir_to_mesa.cpp:458: int type_size(const glsl_type*): Assertion `0' failed.

Comment 1 Ian Romanick 2010-08-06 15:40:26 UTC

This should be fixed by the following commits:

commit 8d61a23b1a1d0d4b21f0fab64f6d863a8ee3d7f1
Author: Eric Anholt <eric@anholt.net>
Date:   Thu Aug 5 16:00:46 2010 -0700

    glsl2: Don't assert in a couple of places when encountering sampler arrays.
    
    Fixes glean shaderAPI.

commit 658e25987fbec3b826f500baa6d4d936b9552b13
Author: Eric Anholt <eric@anholt.net>
Date:   Thu Aug 5 15:54:56 2010 -0700

    ir_to_mesa: Give the expected size for _mesa_add_attribute().
    
    Fixes a failure in glean shaderAPI.

Comment 2 Gordon Jin 2010-08-09 17:42:53 UTC

verified on glsl2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.