Bug 2930

Summary: Use of invalid cairo_matrix_t member in cairo-glitz-surface.c
Product: cairo Reporter: Damien Carbery <damien.carbery>
Component: generalAssignee: Carl Worth <cworth>
Status: RESOLVED FIXED QA Contact: cairo-bugs mailing list <cairo-bugs>
Severity: major    
Priority: high CC: jwatt
Version: 0.9.3   
Hardware: SPARC   
OS: Solaris   
Whiteboard:
i915 platform: i915 features:

Description Damien Carbery 2005-04-08 04:15:46 UTC
cairo-glitz-surface.c (381) references 'm' member of cairo_matrix_t but this
does not exist.

Error:
"cairo-glitz-surface.c", line 381: undefined struct/union member: m
"cairo-glitz-surface.c", line 382: improper member use: m
"cairo-glitz-surface.c", line 383: improper member use: m
"cairo-glitz-surface.c", line 385: improper member use: m
"cairo-glitz-surface.c", line 386: improper member use: m
"cairo-glitz-surface.c", line 387: improper member use: m

cairo.h has:
typedef struct _cairo_matrix {
    double xx; double yx;
    double xy; double yy;
    double x0; double y0;
} cairo_matrix_t;

In cairo-glitz-surface.c (_cairo_glitz_surface_set_matrix function):
transform.matrix[0][0] = _cairo_fixed_from_double (matrix->m[0][0]);
where 'm' is not a member of matrix (type cairo_matrix_t)
Comment 1 Carl Worth 2005-05-10 20:42:52 UTC
It appears that Dave Backett committed a fix for this on 2005-04-08. 
Comment 2 Carl Worth 2005-08-22 17:14:52 UTC
Move bugs against "cvs" version to "0.9.3" so we can remove the "cvs" version.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.