Bug 2931

Summary: void function cairo_matrix_init_identity (src/cairo-matrix.c) returns a value and breaks Solaris build
Product: cairo Reporter: Damien Carbery <damien.carbery>
Component: generalAssignee: Carl Worth <cworth>
Status: RESOLVED FIXED QA Contact: cairo-bugs mailing list <cairo-bugs>
Severity: normal    
Priority: high CC: jwatt
Version: 0.9.3   
Hardware: SPARC   
OS: Solaris   
Whiteboard:
i915 platform: i915 features:

Description Damien Carbery 2005-04-08 04:21:15 UTC
src/cairo-matrix.c (117) has cairo_matrix_init_identity() which is a void
function but the body has:

return cairo_matrix_init (matrix,
                              1, 0,
                              0, 1,
                              0, 0);
This breaks the build on Solaris with Sun One Studio 8 compiler:
$ cc -V
cc: Sun C 5.5 Patch 112761-06 2004/01/13

I created a local patch that simply removes the 'return' keyword.
Comment 1 Carl Worth 2005-04-08 04:43:39 UTC
Thanks, I've just committed this fix.
Comment 2 Carl Worth 2005-08-22 17:14:12 UTC
Move bugs against "cvs" version to "0.9.3" so we can remove the "cvs" version.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.