Bug 29520

Summary:	[glsl2] piglit test glsl-function-prototype fails
Product:	Mesa	Reporter:	Ian Romanick <idr>
Component:	Mesa core	Assignee:	Ian Romanick <idr>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	brian.paul
Version:	git
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Ian Romanick 2010-08-11 16:16:06 UTC

On the swrast driver incorrect rendering is produced, and on the i965 driver a link error is produced.

error: unresolved reference to function `_half'
i965 driver doesn't yet support uninlined function calls.  Move to using a single return statement at the end of the function to work around it.

Comment 1 Ian Romanick 2010-08-11 17:09:29 UTC

Fixed by:

commit 202604e8160157e4e80b3458175e0170d168e557
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Wed Aug 11 16:58:25 2010 -0700

    glsl2: Don't declare a variable called sig that shadows the other one
    
    Accidentally having a variable called 'sig' within an if-statement
    cause the higher scope 'sig' to always be NULL.  As a result a new
    function signature was created for a function definition even when one
    already existed from a prototype declaration.
    
    Fixes piglit test case glsl-function-prototype (bugzilla #29520).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.