Bug 2964

Summary: remove -fsigned-char from GCC options for BE
Product: xorg Reporter: Egbert Eich <eich>
Component: Build/MonolithicAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: high CC: michel
Version: unspecified   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
See above. none

Description Egbert Eich 2005-04-11 03:28:59 UTC 
Olaf hering  suggested to remove the -fsigned-char gcc flag from the compiler
options. Not all BE platforms use it.
Comment 1 Egbert Eich 2005-04-11 03:29:58 UTC 
Created attachment 2388 [details] [review]
See above.
Comment 2 Egbert Eich 2005-04-11 03:38:15 UTC 
This still needs to be tested - but since most platforms don't seem to require
it we may savely leave it out. I frankly don't see why this should be relevant
for BE only anyway.
Comment 3 Egbert Eich 2005-04-11 03:45:43 UTC 
2005-04-11  Egbert Eich  <eich-at-freedesktop-dot-org>

        * config/cf/linux.cf:
        Removing the compiler flag -fsigned-char which is only used
        for a few BE platforms. This still needs some testing - which
        can only be done when in the tree, but since most platforms
        don't need I strongly assume it's not needed. Ticket remains
        open for discussion (Bugzilla #2964).

Committed. 
Not closing ticket for further discussion.
Comment 4 Michel Dänzer 2005-04-11 10:18:28 UTC 
Indeed, it has nothing to do with big endian - ARM is little endian I think.

The reason why this was traditionally necessary is that char is unsigned by
default on these architectures, and code coming from other architectures tends
to assume that char is signed by default. That said, it would definitely be nice
if all those bugs have been fixed, but we need to watch out for odd problems
getting reported on these architectures.
Comment 5 Daniel Stone 2007-02-27 01:26:11 UTC 
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 6 Adam Jackson 2008-07-11 14:33:27 UTC 
Nobody seems to have reported any problems in the intervening three years.  Closing.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.