Bug 29640

Summary:	[glsl2]Mesa demo vpglsl render incorrectly
Product:	Mesa	Reporter:	wang,jinjin <jinjin.wang>
Component:	Drivers/DRI/i965	Assignee:	Eric Anholt <eric>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	git
Hardware:	All
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	test picture with i965 test picture with swrast

Description wang,jinjin 2010-08-17 23:36:38 UTC

System Environment:
--------------------------
Arch:       x86_64
Platform:   Calpella/Piketon
Libdrm:         (master)2.4.21-15-gb04515c5d6c95f573457a94267b855cceb639105
Mesa:        (master) commit d01c0025e81e713d99f4de9ed7f4cdd12a1d08b5
Xserver:                (master)xorg-server-1.8.99.905-12-g8d7b7a0d71e0b89321b3341b781bc8845386def6
Cairo:          (master)046b642db0782ab5e2a5c82988b21e05afe8e716
Kernel: (for-linus)9fe6206f400646a2322096b56c59891d530e8d51

Bug detailed description:
-------------------------
With Mesa (master) commit d01c0025e81e713d99f4de9ed7f4cdd12a1d08b5, Mesa demo vpglsl with the func2.glsl display differently between swrast and i965.That also be found in glsl2 branch commit a433cd286c60eb9d4c2114f042709eda0f3de676.

Reproduce steps:
----------------
1.xinit& 
2. Mesa_demos/src/vpglsl/vp-tris  func2.glsl

Comment 1 wang,jinjin 2010-08-17 23:39:03 UTC

Created attachment 37939 [details]
test picture with i965

Comment 2 wang,jinjin 2010-08-17 23:39:59 UTC

Created attachment 37940 [details]
test picture with swrast

Comment 3 Eric Anholt 2010-08-18 21:48:12 UTC

commit bad29dc6dad7ed1bff46c67e61dab01f8d82b557
Author: Eric Anholt <eric@anholt.net>
Date:   Wed Aug 18 21:18:23 2010 -0700

    i965: Don't set the swizzle on an immediate value in the VS.
    
    Fixes glsl-vs-if-nested (70.0 is not <= 70.000648 thanks to the
    swizzle bits getting set).  Some safety checks are added to make sure
    this doesn't happen again as we increase the usage of immediate values
    in program generation.

Comment 4 wang,jinjin 2010-08-19 02:54:06 UTC

Thanks Eric Anholt. I verified it render correctly with the commit bad29dc6dad7ed1bff46c67e61dab01f8d82b557.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.