Summary: | [regression] Post-GLSL2 Mesa culls too much by default. | ||
---|---|---|---|
Product: | Mesa | Reporter: | Cedric Vivier <cedricv> |
Component: | Mesa core | Assignee: | mesa-dev |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | medium | CC: | cedricv |
Version: | git | ||
Hardware: | x86 (IA32) | ||
OS: | Linux (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: |
Description
Cedric Vivier
2010-08-27 03:41:03 UTC
We've got some discard tests that look a lot like that, and they pass on swrast and 965. What hardware are you using? If you can reproduce the problem with swrast, could you make a piglit shader_runner testcase for your particular failure? I've tested on both i965 and swrast, it gives same result. Eric, which discard tests are you specifically talking about ? In case the report is confusing, 'discard' itself is not the issue here, it's just an easily reproducible mean to notice that recent Mesa is culling/optimizing out some (not all) back-facing (and only back-facing) polygons that would have been over-drawn if there were no 'discard'. Nope, it really was about discard. We weren't telling swrast and 965 that a pixel kill happened, so depth writes went ahead and then those backfaces would get culled (sometimes, depending on the order the triangles were processed). piglit: commit 99c3ae0b4889af94b98fd8722e4b501764741263 Author: Eric Anholt <eric@anholt.net> Date: Tue Aug 31 12:36:31 2010 -0700 glsl-fs-discard-02: Test that early depth writes don't happen with "discard" mesa: commit 9b075cb9fa9eb6a95d0816283ef01ae72dafa680 Author: Eric Anholt <eric@anholt.net> Date: Tue Aug 31 13:02:59 2010 -0700 ir_to_mesa: When emitting a pixel kill, flag that we did so. Both i965 and swrast rely on UsesKill to determine whether to do early depth writes. Fixes glsl-fs-discard-02. Bug #29835. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.