Bug 29838

Summary:	Compiling code that uses tpqt4 results in loads of warnings with -Wshadow
Product:	Telepathy	Reporter:	George Goldberg <grundleborg>
Component:	tp-qt	Assignee:	George Goldberg <grundleborg>
Status:	RESOLVED INVALID	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	lowest	CC:	ollisal
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description George Goldberg 2010-08-27 05:05:00 UTC

Compiling code that uses tpqt4 results in loads of warnings with -Wshadow

I'm not sure if any of these actually matter, but in case they do...

Here are some fragments of compiler output in case they are useful.

In file included from /opt/kde/include/telepathy-1.0/TelepathyQt4/SharedPtr:8,                                                                                                                  
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/types.h:32,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/Types:8,
                 from /home/gberg/development/src/work/collabora/libktelepathy/src/jobs/abstractrequestchanneljob_p.h:30,
                 from /home/gberg/development/src/work/collabora/libktelepathy/src/jobs/requesttextchatroomjob.cpp:20:
/opt/kde/include/telepathy-1.0/TelepathyQt4/shared-ptr.h: In constructor 'Tp::WeakData::WeakData(Tp::RefCounted*)':
/opt/kde/include/telepathy-1.0/TelepathyQt4/shared-ptr.h:46: warning: declaration of 'd' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/shared-ptr.h: In constructor 'Tp::SharedPtr<T>::SharedPtr(T*)':
/opt/kde/include/telepathy-1.0/TelepathyQt4/shared-ptr.h:72: warning: declaration of 'd' shadows a member of 'this'
In file included from /opt/kde/include/telepathy-1.0/TelepathyQt4/MethodInvocationContext:8,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/types.h:33,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/Types:8,
                 from /home/gberg/development/src/work/collabora/libktelepathy/src/jobs/abstractrequestchanneljob_p.h:30,
                 from /home/gberg/development/src/work/collabora/libktelepathy/src/jobs/requesttextchatroomjob.cpp:20:
/opt/kde/include/telepathy-1.0/TelepathyQt4/method-invocation-context.h: In member function 'void Tp::MethodInvocationContext<T1, T2, T3, T4, T5, T6, T7, T8>::setFinishedWithError(const QString&, const QString&)':
/opt/kde/include/telepathy-1.0/TelepathyQt4/method-invocation-context.h:134: warning: declaration of 'errorMessage' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/method-invocation-context.h:134: warning: declaration of 'errorName' shadows a member of 'this'
In file included from /opt/kde/include/telepathy-1.0/TelepathyQt4/dbus.h:51,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/DBus:8,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:32,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/Connection:8,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/account.h:31,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/Account:8,
                 from /home/gberg/development/src/work/collabora/libktelepathy/src/jobs/requesttextchatroomjob.cpp:22:
/opt/kde/include/telepathy-1.0/TelepathyQt4/_gen/cli-dbus.h: In member function 'QDBusPendingReply<unsigned int, void, void, void, void, void, void, void> Tp::Client::DBus::DBusDaemonInterface::StartServiceByName(const QString&, uint)':
/opt/kde/include/telepathy-1.0/TelepathyQt4/_gen/cli-dbus.h:175: warning: declaration of 'service' shadows a member of 'this'
In file included from /opt/kde/include/telepathy-1.0/TelepathyQt4/OptionalInterfaceFactory:8,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:34,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/Connection:8,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/account.h:31,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/Account:8,
                 from /home/gberg/development/src/work/collabora/libktelepathy/src/jobs/requesttextchatroomjob.cpp:22:
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:110: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'void Tp::OptionalInterfaceFactory<DBusProxySubclass>::setInterfaces(const QStringList&)':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:118: warning: declaration of 'interfaces' shadows a member of 'this'
/home/gberg/development/src/work/collabora/libktelepathy/src/jobs/requesttextchatroomjob.cpp: In constructor 'KTelepathy::RequestTextChatroomJob::RequestTextChatroomJob(KTelepathy::RequestTextChatroomJobPrivate&, QObject*)':
/home/gberg/development/src/work/collabora/libktelepathy/src/jobs/requesttextchatroomjob.cpp:78: warning: declaration of 'parent' shadows a member of 'this'
In file included from /opt/kde/include/telepathy-1.0/TelepathyQt4/OptionalInterfaceFactory:8,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:34,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/Connection:8,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/account.h:31,
                 from /opt/kde/include/telepathy-1.0/TelepathyQt4/Account:8,
                 from /home/gberg/development/src/work/collabora/libktelepathy/src/jobs/requesttextchatroomjob.cpp:22:
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::DBus::PropertiesInterface, DBusProxySubclass = Tp::Connection]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::DBus::PropertiesInterface, DBusProxySubclass = Tp::Connection]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:120:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::ConnectionInterfaceAliasingInterface, DBusProxySubclass = Tp::Connection]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::ConnectionInterfaceAliasingInterface, DBusProxySubclass = Tp::Connection]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:126:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::ConnectionInterfaceAnonymityInterface, DBusProxySubclass = Tp::Connection]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::ConnectionInterfaceAnonymityInterface, DBusProxySubclass = Tp::Connection]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:132:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::ConnectionInterfaceAvatarsInterface, DBusProxySubclass = Tp::Connection]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::ConnectionInterfaceAvatarsInterface, DBusProxySubclass = Tp::Connection]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:138:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::ConnectionInterfaceCapabilitiesInterface, DBusProxySubclass = Tp::Connection]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::ConnectionInterfaceCapabilitiesInterface, DBusProxySubclass = Tp::Connection]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:144:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::ConnectionInterfaceContactCapabilitiesInterface, DBusProxySubclass = Tp::Connection]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::ConnectionInterfaceContactCapabilitiesInterface, DBusProxySubclass = Tp::Connection]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:150:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::ConnectionInterfaceLocationInterface, DBusProxySubclass = Tp::Connection]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::ConnectionInterfaceLocationInterface, DBusProxySubclass = Tp::Connection]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:156:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::ConnectionInterfaceContactInfoInterface, DBusProxySubclass = Tp::Connection]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::ConnectionInterfaceContactInfoInterface, DBusProxySubclass = Tp::Connection]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:162:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::ConnectionInterfacePresenceInterface, DBusProxySubclass = Tp::Connection]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::ConnectionInterfacePresenceInterface, DBusProxySubclass = Tp::Connection]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:168:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::ConnectionInterfaceServicePointInterface, DBusProxySubclass = Tp::Connection]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::ConnectionInterfaceServicePointInterface, DBusProxySubclass = Tp::Connection]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:174:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::ConnectionInterfaceSimplePresenceInterface, DBusProxySubclass = Tp::Connection]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::ConnectionInterfaceSimplePresenceInterface, DBusProxySubclass = Tp::Connection]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:180:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::ConnectionInterfaceRequestsInterface, DBusProxySubclass = Tp::Connection]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::ConnectionInterfaceRequestsInterface, DBusProxySubclass = Tp::Connection]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:186:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::ConnectionInterfaceBalanceInterface, DBusProxySubclass = Tp::Connection]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::ConnectionInterfaceBalanceInterface, DBusProxySubclass = Tp::Connection]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:192:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::ConnectionInterfaceCellularInterface, DBusProxySubclass = Tp::Connection]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::ConnectionInterfaceCellularInterface, DBusProxySubclass = Tp::Connection]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/connection.h:198:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::DBus::PropertiesInterface, DBusProxySubclass = Tp::Account]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::DBus::PropertiesInterface, DBusProxySubclass = Tp::Account]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/account.h:278:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h: In member function 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::interface() const [with Interface = Tp::Client::AccountInterfaceAvatarInterface, DBusProxySubclass = Tp::Account]':
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:94:   instantiated from 'Interface* Tp::OptionalInterfaceFactory<DBusProxySubclass>::optionalInterface(Tp::OptionalInterfaceFactory<DBusProxySubclass>::InterfaceSupportedChecking) const [with Interface = Tp::Client::AccountInterfaceAvatarInterface, DBusProxySubclass = Tp::Account]'
/opt/kde/include/telepathy-1.0/TelepathyQt4/account.h:284:   instantiated from here
/opt/kde/include/telepathy-1.0/TelepathyQt4/optional-interface-factory.h:111: warning: declaration of 'interface' shadows a member of 'this'

Comment 1 Olli Salli 2011-12-29 07:35:48 UTC

This seems to be from a very old (<=0.4) tp-qt version. Could you re-check which warnings actually occur with tp-qt >=0.9 and attach a report, please?

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.