Bug 29848

Summary: [llvmpipe] piglit point-sprite regression
Product: Mesa Reporter: Vinson Lee <vlee>
Component: OtherAssignee: Keith Whitwell <keithw>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: medium CC: brianp, jfonseca
Version: git   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 30124    
Attachments: point-sprite.png

Description Vinson Lee 2010-08-27 23:11:51 UTC
Created attachment 38231 [details]
point-sprite.png

mesa: 120d5a95cb983b0b983089ba415486c55a9196e3 (master)

piglit point-sprite now fails but previously passed.

$ ./bin/point-sprite
Maximum point size is 255.000000, using 64.000000
Probe at (17,114)
  Expected: 1.000000 1.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
  size = 64.000, origin = lower left
Probe at (90,106)
  Expected: 1.000000 1.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
  size = 32.000, origin = lower left
Probe at (159,102)
  Expected: 1.000000 1.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
  size = 16.000, origin = lower left
Probe at (226,100)
  Expected: 1.000000 1.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
  size = 8.000, origin = lower left
Probe at (292,99)
  Expected: 1.000000 1.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
  size = 4.000, origin = lower left
Probe at (357,98)
  Expected: 1.000000 1.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
  size = 2.000, origin = lower left
Comment 1 Vinson Lee 2010-08-27 23:49:31 UTC
29ec116e8f21c65250f1083830b82ff59859496d is the first bad commit
commit 29ec116e8f21c65250f1083830b82ff59859496d
Author: Hui Qi Tay <hqtay@vmware.com>
Date:   Tue Aug 10 11:41:32 2010 +0100

    llvmpipe: point sprites rasterization
    
    Point sprites now done in the rasterizer setup code instead of
    going through the draw module.

:040000 040000 ca99985846bc49a5e6f7e36b05c55cab23601688 6f427b89645216bbabf511c1fbdbaa9a5df504fe M	src
bisect run success
Comment 2 Brian Paul 2010-09-21 12:34:30 UTC
Fixed as of Mesa commit b3a647276e5fae570628826961c9b86612c2a2c6.
Comment 3 Vinson Lee 2010-09-21 14:06:08 UTC
mesa: 45d10c7d5910ada45b3bf7c34f9fb98c80c72664 (master)

Verified fixed.


mesa: 2606105cc5c452f32e3b3418e474e3c71702534a (7.9)

Still fails.
Comment 4 Brian Paul 2010-09-22 10:29:51 UTC
Fixed on 7.9 branch w/ commit 3cdfc6252394541e28e8290b7539bd1b132ea004
Comment 5 Vinson Lee 2010-09-27 09:40:17 UTC
mesa: 99c422ef5ab3924aad66af026945f491d75d226f (master)
mesa: 7e62335f35d4ed1ea269be801fbb95f2587f3ebc (7.9)

Verified fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.