Bug 29859

Summary:	xdg-screensaver - Change screensaver_freedesktop's interpretation of GetActive
Product:	Portland	Reporter:	Michael T. Dean <mtdean>
Component:	xdg-utils	Assignee:	Fathi Boudra <fabo>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	1.1.0
Hardware:	Other
OS:	All
See Also:	https://bugs.freedesktop.org/show_bug.cgi?id=26085
Whiteboard:
i915 platform:		i915 features:
Attachments:	Change screensaver_freedesktop's interpretation of GetActive

Description Michael T. Dean 2010-08-28 19:15:28 UTC

Created attachment 38252 [details] [review]
Change screensaver_freedesktop's interpretation of GetActive

The freedesktop screensaver D-Bus API method GetActive seems to return boolean to indicate whether the screensaver is active ("saving" the screen), not whether the screensaver program is enabled.  Therefore, the attached patch changes the interpretation of the response to GetActive such that a successful response (either true or false) indicates the screensaver program is enabled (even if not active) and a successful response that does not specify true or false indicates that the screensaver program is disabled.

Comment 1 Michael T. Dean 2012-04-18 19:20:18 UTC

Linking to related patch at https://bugs.freedesktop.org/show_bug.cgi?id=26085#c6 , which is also necessary to make KDE screensaver support work properly with the DBus API.

Note, also, that this patch and the linked patch were the basis of the GNOME screensaver support patch in Bug #29860, that was accepted.

Comment 2 Rex Dieter 2015-01-15 16:10:36 UTC

committed,
http://cgit.freedesktop.org/xdg/xdg-utils/commit/?id=8e9fa9bcc85fd31d4548870aad27c0593f64c433


thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.