Bug 29903

Summary:	vd_agent_char_device_wakeup is called from separate thread, causing potential races
Product:	Spice	Reporter:	Alon Levy <alevy>
Component:	server	Assignee:	Spice Bug List <spice-bugs>
Status:	RESOLVED MOVED	QA Contact:
Severity:	enhancement
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	add 640x480, 256 colors video mode to qxl.c

Description Alon Levy 2010-08-31 02:57:51 UTC

guest paste:
 per cpu thread:
 kvm_main_loop_cpu..vmc_have_data..spice_server_vdi_port_wakeup
  ..read_from_vdi_port

client message (mouse / clipboard)
 qemu/kvm main thread:
 main_loop..inputs_event..reds_handle_agent_mouse_event..write_to_vdi_port

We need to either be very sure there is no touching of the same data structures,
or relay the data over to one thread (the main thread).

Both spice-vmc write and virtio-serial write functions are not thread safe.

Comment 1 pdfan 2010-09-05 03:29:20 UTC

Created attachment 38449 [details] [review]
add 640x480, 256 colors video mode to qxl.c

qxl does not support 640x480, 256 colors video mode. so that some old program can not run

I recently tried qemu-kvm-spice, and I tried to add 640x480, 256 colors video mode in qxl.c. 

but this mode is not listed in the all supported mode for the qxl adapter for choosing.

I guess the qxl win32 driver does not support it, though the virtual qxl adapter support it.

Comment 2 GitLab Migration User 2018-06-03 10:15:21 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/spice/spice-server/issues/16.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.