Bug 29925

Summary:	[i915 bisected] glean pixelFormats fails with GLES disabled
Product:	Mesa	Reporter:	jiajia <jiajia.zheng>
Component:	Drivers/DRI/i915	Assignee:	Eric Anholt <eric>
Status:	VERIFIED FIXED	QA Contact:	fangxun <xunx.fang>
Severity:	normal
Priority:	medium
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	output

Description jiajia 2010-09-01 00:28:38 UTC

Test environment:
-----------------
Platform:       Pineview		
OSD:		Fedora release 12 (Constantine)
Kernel_version:		2.6.36-rc2_unstable_20100831+
Libdrm:		(master)2.4.21-18-g23287f05cf2443ddf9e028e29beb5bd30979c6cf
Mesa:		(master)3fbbd70e80033566f5d7015fa2110a9d355bcfa4

Comment 1 jiajia 2010-09-01 00:34:11 UTC

Created attachment 38344 [details]
output

Comment 2 jiajia 2010-09-01 00:35:14 UTC

We've bisected this issue.
61aa9c86c20b1bc9957aa9fe9976703a93cc4d3c is the first bad commit

Comment 3 jiajia 2010-09-01 00:38:54 UTC

commit 61aa9c86c20b1bc9957aa9fe9976703a93cc4d3c
Author: Eric Anholt <eric@anholt.net>
Date:   Thu May 13 10:13:52 2010 -0700

    intel: Don't update window system renderbuffers on TexImage.

    While sometimes rendering occurs in the form of blits for TexImage, it
    doesn't interact with the window system renderbuffers, so skip it.

Comment 4 Eric Anholt 2011-07-12 16:09:38 UTC

Definitely looks like this commit, even though this bug report was separate from the gles2-enabled one.

commit 6e6b38860488a0b2b282866f095cea9860503a14
Author: Eric Anholt <eric@anholt.net>
Date:   Mon Jul 11 11:32:04 2011 -0700

    i915: Fix map/unmap mismatches from leaving INTEL_FALLBACK during TNL.
    
    The first rendering after context create didn't know of the color
    buffer yet, triggering a sw fallback.  The intel_prepare_render() from
    intelSpanRenderStart then found the buffer and turned off fallbacks,
    but intelSpanRenderFinish was never called and things were left
    mapped.  By checking buffers before making the call on whether to do
    the fallback pipeline or not, we avoid the fallback change inside of
    the rendering pipeline.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=31561
    Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>

Comment 5 Gordon Jin 2011-08-25 18:21:05 UTC

Xun, can you help verify?

Comment 6 fangxun 2011-08-26 02:28:23 UTC

Verifid with Mesa(master)7b1972d7be8ed68676786288ac2d77b8d71d113d.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.