Bug 29974

Summary:	handle rate limiting in the providers
Product:	GeoClue	Reporter:	Stefan Kost <ensonic>
Component:	General	Assignee:	Geoclue Bugs <geoclue-bugs>
Status:	RESOLVED WONTFIX	QA Contact:	Geoclue Bugs <geoclue-bugs>
Severity:	enhancement
Priority:	medium	CC:	wolf+meego
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Stefan Kost 2010-09-02 07:24:48 UTC

this commit handles rate limiting on the client side.
http://cgit.freedesktop.org/geoclue/commit/?id=7659ad9ae22d78a240d8c81f8217c3937fcadd88

Ideally the "min_time" value is passed to the geoclue provider. So that they can rate limit g_signal_emit() and event the update interval from the hardware or webservice.

Comment 1 Ross Burton 2010-09-16 08:26:09 UTC

Yes, it should be passed all the way down to the providers.  We should probably split this up into a bug per provider that it affects.

Comment 2 Juha Vuolle 2010-10-06 18:26:55 UTC

The issue with the patch Stefan mentioned is that it is lossy, it will just discard any updates during the min_time. 

That is problematic for clients who wish to "have the best available update" "once every min_time". For me that seems a more common use-case than a simple ignore timer. Especially if considering rarely changing less-accurate sources, where one wouldn't want to miss an update.

Comment 3 Zeeshan Ali 2013-09-09 14:50:12 UTC

Closing all bugs on old geoclue. If your bug still applies to new geoclue, please do re-open, I really don't have time to go through each and every bug and evaluate separately. :( Apologies for any inconvenience caused by this change.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.