Bug 30045

Summary:	mesa fails to build when configured --disable-driglx-direct
Product:	Mesa	Reporter:	Jon Turney <jon.turney>
Component:	GLX	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Some fixes for GLX_INDIRECT_RENDERING only build

Description Jon Turney 2010-09-06 08:48:35 UTC

mesa fails to build when configured --disable-driglx-direct

[...]
glxcmds.c: In function ‘glx_context_init’:
glxcmds.c:239: error: ‘struct glx_screen’ has no member named ‘scr’
glxcmds.c: In function ‘__glXGetVideoSyncSGI’:
[...]

Comment 1 Jon Turney 2010-09-06 08:51:59 UTC

Created attachment 38478 [details] [review]
Some fixes for GLX_INDIRECT_RENDERING only build

Attached patch fixes some (not all) of GLX_INDIRECT_RENDERING and !GLX_DIRECT_RENDERING build issues.

There still remain some issues with the use of psc->dpy in indirect_glx.c.  I'm not sure if changing to use psc->display->dpy is sematically the same.  In which case psc->dpy could be removed?

Comment 2 Kristian Høgsberg 2010-09-07 09:46:52 UTC

(In reply to comment #1)
> Created an attachment (id=38478) [details]
> Some fixes for GLX_INDIRECT_RENDERING only build
> 
> Attached patch fixes some (not all) of GLX_INDIRECT_RENDERING and
> !GLX_DIRECT_RENDERING build issues.
> 
> There still remain some issues with the use of psc->dpy in indirect_glx.c.  I'm
> not sure if changing to use psc->display->dpy is sematically the same.  In
> which case psc->dpy could be removed?

I moved the fields out of the direct-rendering conditional.  Using psc->display->dpy should work too and eliminating psc->dpy would be less redundant, but we're trying to release 7.9 in a few weeks, so I'd like to hold off until then.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.