| Summary: | Fix various build warnings in telepathy-mission-control | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Vincent Untz <vuntz> |
| Component: | mission-control | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | 5.6 | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | Trivial patch | ||
|
Description
Vincent Untz
2010-09-15 00:21:51 UTC
Something must have gone wrong with our compiler-warnings setup, again. I'll get this patch or something similar applied for 5.6. (Note that all of these are in helpers for regression tests, so nothing changes in the installed binaries as a result.) (In reply to comment #0) > This patch fixes various obvious build warnings (by adding missing includes and > other trivial fixes). Thanks, your changes all look good. Fixed in git for 5.5.5, or for the 5.6.0 stable release if we decide we don't need another release-candidate. > It's actually need to get a package in openSUSE for > telepathy-mission-control 5.5.4... If you're doing -Werror=format-security or something, with specific errors that are unlikely to have false positives, then that's fair enough; if you're building distro packages with -Werror, I really wouldn't advise that. > There's still: > account-store.c:198:3: warning: enumeration value 'OP_UNKNOWN' not handled in > switch I fixed that too, since non-release versions of MC build with -Werror. I'm not sure how my build succeeded when I merged those patches in the first place :-( (In reply to comment #2) > (In reply to comment #0) > > It's actually need to get a package in openSUSE for > > telepathy-mission-control 5.5.4... > > If you're doing -Werror=format-security or something, with specific errors that > are unlikely to have false positives, then that's fair enough; if you're > building distro packages with -Werror, I really wouldn't advise that. We're not doing -Werror. But we have post-build checks that look at the warnings during the build, and does the same as -Werror=format-security (for a few more warnings, though). |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.