Bug 30217

In Mesa-7.8.3-rc1/src/mesa/drivers/dri/intel/intel_context.c, &intel->ViewportMatrix is allocated

123    _math_matrix_ctr(&intel->ViewportMatrix);

but does not appear to ever be released. Valgrind reports a memory leak associated with this _math_matrix_ctr call.

To address this, I added the following lines (*), which appears to fix this, but this may not be the appropriate place to do this:

837 
838       driDestroyOptionCache(&intel->optionCache);
839
*         /* free ViewportMatrix resources */ 
*         _math_matrix_dtr(&intel->ViewportMatrix);
*
840       /* free the Mesa context */
841       _mesa_free_context_data(&intel->ctx);
842 
843       FREE(intel);
844       driContextPriv->driverPrivate = NULL;

-----------------------------------------------------------------------
In Mesa-7.8.3-rc1/src/mesa/drivers/dri/intel/intel_fbo.c, there are cases where
intel_delete_renderbuffer is entered when intel != true but irb->region = true.
Valgrind reports a memory leak associated with this. To address this, I added the following lines (*), which appears to fix this, but this may not be a correct/proper thing to do:

 65 /** Called by gl_renderbuffer::Delete() */
 66 static void
 67 intel_delete_renderbuffer(struct gl_renderbuffer *rb)
 68 {
 69    GET_CURRENT_CONTEXT(ctx);
 70    struct intel_context *intel = intel_context(ctx);
 71    struct intel_renderbuffer *irb = intel_renderbuffer(rb);
 72 
 73    ASSERT(irb);
 74 
*75    //if (intel && irb->region) {
*      if (irb->region) {
 76       intel_region_release(&irb->region);
 77    }
 78 
 79    free(irb);
 80 }

thanks for your time
John