Bug 30236

Created attachment 38755 [details] [review]
Add keymap that will extend USA map with Indian Rupee

You are adding both option and special variant, just for that option. Is that right? I do not like that.

What I propose is the following: let's add only XKB option. And in base.xml, let's combine eurosign and rupeesign under the same tree: "National currency characters".

What do you think?

I just followed what I saw about Euro sign in source code. What is difference between adding as a option and group?

Created attachment 38808 [details] [review]
Add keymap that will extend USA map with Indian Rupee

I have removed group adding code.

The group is more "namespace" thing. Your last patch is ok - except I'd prefer not to create in(rupee) symbols - let people use rupeesign option if they want.

Since we're currently in freeze, your patch will go into the next release, will be committed after I release 2.0 (next Tuesday)

(In reply to comment #5)
> The group is more "namespace" thing. Your last patch is ok - except I'd prefer
> not to create in(rupee) symbols - let people use rupeesign option if they want.

Sorry can you please explain what above mean? Do you need some more changes in patch?

> 
> Since we're currently in freeze, your patch will go into the next release, will
> be committed after I release 2.0 (next Tuesday)

Ok. I thought it would have been good if this patch is included with other nbsp fix in 2.0 release.

> Sorry can you please explain what above mean? Do you need some more changes in
> patch?
Yes. In base.xml.in, I'd change "euro" options group to "currency" group (with euro:* and rupeesign:4 options).
I would not change symbols/in (and would not add in(rupee) variant to base.xml.in).

> Ok. I thought it would have been good if this patch is included with other nbsp
> fix in 2.0 release.
nbsp fix was there for quite a while, it will be in 2.0 (it is critical fix anyway, not breaking the freeze on rules subdir).
The rupee patch will go to 2.1

(In reply to comment #7)
> > Sorry can you please explain what above mean? Do you need some more changes in
> > patch?
> Yes. In base.xml.in, I'd change "euro" options group to "currency" group (with
> euro:* and rupeesign:4 options).
> I would not change symbols/in (and would not add in(rupee) variant to
> base.xml.in).
> 
  I see eurosign:4 option already present in base.xml.in file. will adding rupeesign:4 place euro and rupee sign on same key?
  When tried to add rupeesign option to us map, the UI seems confusing as I got 2 checkboxes with label "4". Also, as requested need AltGr+4 to provide rupeesign. 
I think then I need to enable another option "ALT_R"

>   I see eurosign:4 option already present in base.xml.in file. will adding
> rupeesign:4 place euro and rupee sign on same key?
No, they will be different XKB options.

>   When tried to add rupeesign option to us map, the UI seems confusing as I got
> 2 checkboxes with label "4". Also, as requested need AltGr+4 to provide
> rupeesign. 
I understand. We'll change the desciption: Euro at 4, Euro at E, Euro at 5, Rupee at 4.

Sergey, so how do you propose to deal with this new
layout for India?  Though it is largely based on USA
layout there are two changes (adding RupeeSign and
addition of AltGr) - this layout is going to be the
default layout for all India locales instead of current
USA, so there needs to be an easy way to set this layout
and it should definitely appear under India layouts
in the GUI.(

Also, as per http://en.wikinews.org/wiki/India_approves_symbol_for_currency, rupee sign will be added to Keyboards for easy use

> Sergey, so how do you propose to deal with this new
> layout for India?  Though it is largely based on USA
> layout there are two changes (adding RupeeSign and
> addition of AltGr) - this layout is going to be the
> default layout for all India locales instead of current
> USA, 
Wait a sec. This is getting very serious. What you are saying is that new variant in symbols/in (essentially 'us' + small additions) is going to be the default variant for India. Right? Does it mean that all/most keyboard sold in India have corresponding engravings?

My idea was just to add XKB option, so any layout (us,fr,ru,...) could be 'rupee-enabled' with a single checkbox. That would eliminate the need in special variant. But if you're escalating the case to the higher level (changing the default variant for India), we can discuss that.

Also, currently the default variant for India is Devangari

> Wait a sec. This is getting very serious. What you are saying is that new
> variant in symbols/in (essentially 'us' + small additions) is going to be the
> default variant for India. Right? Does it mean that all/most keyboard sold in
> India have corresponding engravings?
> 
Yes. It will be.

> My idea was just to add XKB option, so any layout (us,fr,ru,...) could be
> 'rupee-enabled' with a single checkbox. That would eliminate the need in
> special variant. But if you're escalating the case to the higher level
> (changing the default variant for India), we can discuss that.
> 
> Also, currently the default variant for India is Devangari

yes default variant for India is Devanagari currently.

Just got the information that Government of India will take some time(can be six months) to officially release it. Can it be possible to add new keymap that adds rupeesign as "India - Latin (experimental)" till we get its official release?

Its ok if we at least get this under list of India keymaps but not as default variant for now. Later on we can make this as default.

Ok, I have committed your patch. And polished it a bit:

http://cgit.freedesktop.org/xkeyboard-config/commit/?id=396de5b7138f25e49f4de3a0c871f09f08619867

Hope you do not mind me changing some bits?

Parag, could you please comment on

https://bugs.freedesktop.org/show_bug.cgi?id=106292

?

Thank you!