Bug 30249

Summary:	--with-openssl-dir configure option always set use_openssl="no"
Product:	UIM	Reporter:	OBATA Akio <obache>
Component:	Other	Assignee:	uim-bugs
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch for openssl.m4

Description OBATA Akio 2010-09-17 19:17:01 UTC

With uim-1.6.0.
If --enable-openssl --with-openssl-dir=/some/dir are passed to configure script, openssl will be detected, but always use_openssl="no" is set, so openssl plugin will not be built.

I'm not sure it come from incorrect use of AC_ARG_WITH or a bug of autoconf.

Comment 1 Muneyuki Noguchi 2010-09-18 02:11:52 UTC

Created attachment 38776 [details] [review]
patch for openssl.m4

Could you test this patch?

Comment 2 OBATA Akio 2010-09-18 03:48:16 UTC

(In reply to comment #1)
> Created an attachment (id=38776) [details]
> patch for openssl.m4
> 
> Could you test this patch?

Yes, it fixes this issue!

Comment 3 Muneyuki Noguchi 2010-09-18 04:10:26 UTC

OK, fixed in the trunk (r6783).

Comment 4 Etsushi Kato 2010-09-28 20:33:04 UTC

(In reply to comment #3)
> OK, fixed in the trunk (r6783).

The change has caused to set 'use_openssl="no"' if the argument is not specified.  We shouldn't set any value when ACTION-IF-NOT-GIVEN, and fix has been committed in r6785.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.