Bug 30337

Summary:	[r300g bisected] Starcraft 2: circles around units are corrupted
Product:	Mesa	Reporter:	Pavel Ondračka <pavel.ondracka>
Component:	Drivers/Gallium/r300	Assignee:	Default DRI bug account <dri-devel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	tstellar
Version:	unspecified	Keywords:	regression
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	comparison of good (left) bad (right) behaviour output with RADEON_DEBUG=fp, mesa 59276b8541049a2d07d32fbb139fb14e21e387fc Possible Fix RADEON_DEBUG=fp output with patch applied Fix v2 Fix v3 - This one should work.

Description Pavel Ondračka 2010-09-23 01:33:30 UTC

Created attachment 38895 [details]
comparison of good (left) bad (right) behaviour

When running Starcraft 2, there should be thin circle around selected units or buildings, however big square filled with colour is being drawn instead. This is with Wine 1.3.3 (also happens with other versions) and GLSL disabled in Wine.

564653b9f196b9bf91fe772fd1ca1e131ff33774 is the first bad commit
commit 564653b9f196b9bf91fe772fd1ca1e131ff33774
Author: Tom Stellard <tstellar@gmail.com>
Date:   Mon Sep 6 10:57:20 2010 -0700

    r300/compiler: Add peephole optimization for the 'sub' presubtract operation

:040000 040000 a0618411740d18c4769e6284bb943fb583c29d2d 02240349d7832ff252896acce15da24964f0a462 M	src

Comment 1 Tom Stellard 2010-09-23 16:06:39 UTC

Can you post the output of RADEON_DEBUG=fp?  You can probably get around this bug for now by running with RADEON_DEBUG=noopt

Comment 2 Pavel Ondračka 2010-09-23 23:16:26 UTC

Created attachment 38922 [details]
output with RADEON_DEBUG=fp, mesa 59276b8541049a2d07d32fbb139fb14e21e387fc

BTW workaround with RADEON_DEBUG=noopt indeed fixes this.

Comment 3 Tom Stellard 2010-09-23 23:48:58 UTC

Created attachment 38923 [details] [review]
Possible Fix

Here is a possible fix.  If it doesn't work, please post the output of RADEON_DEBUG=fp with this patch applied.

Comment 4 Pavel Ondračka 2010-09-24 01:02:49 UTC

Created attachment 38924 [details]
RADEON_DEBUG=fp output with patch applied

Comment 5 Tom Stellard 2010-09-24 17:34:12 UTC

Created attachment 38942 [details] [review]
Fix v2

Can you try this patch?  Apply it to directly to master.

Comment 6 Tom Stellard 2010-09-24 23:32:26 UTC

Created attachment 38948 [details] [review]
Fix v3 - This one should work.

Apply this directly to master.

Comment 7 Pavel Ondračka 2010-09-25 00:22:02 UTC

(In reply to comment #3)
> Created an attachment (id=38923) [details]
> Possible Fix
> 
> Here is a possible fix.  If it doesn't work, please post the output of
> RADEON_DEBUG=fp with this patch applied.

Thank you, with this patch there is no more corruption.

Comment 8 Tom Stellard 2010-09-25 22:40:05 UTC

Fixed in git by commit 522e994a22e8b46c8a41f2920af88c5ebad43cd8

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.