Bug 30346

Summary: Delete GibberResolver
Product: Telepathy Reporter: Jasper Lievisse Adriaanse <jasper>
Component: salutAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: All   
OS: All   
URL: http://git.collabora.co.uk/?p=user/smcv/salut-smcv.git;a=shortlog;h=refs/heads/mischttp://git.collabora.co.uk/?p=user/smcv/salut-smcv.git;a=shortlog;h=refs/heads/misc
Whiteboard: r+
i915 platform: i915 features:
Attachments: Fix build

Description Jasper Lievisse Adriaanse 2010-09-23 07:47:15 UTC
Created attachment 38902 [details]
Fix build

Some systems, like OpenBSD don't have NS_GET16 defined.
Attached diff fixes the build in the least intrusive way.
Comment 1 Simon McVittie 2010-09-23 08:19:06 UTC
I don't think GibberResolver is used in Salut, and it's no longer used in Gibber's other user (Gabble) either, so I suspect we can just delete it.
Comment 2 Simon McVittie 2010-09-23 08:57:03 UTC
It turns out we can indeed just delete it.
Comment 3 Guillaume Desmottes 2010-09-24 00:37:30 UTC
++
Comment 4 Simon McVittie 2010-09-24 02:54:35 UTC
Fixed in git for version 0.3.14.

(Thanks for trying for a least-intrusive fix, but it turned out that in this case the most intrusive fix was even better :-)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.