Bug 30505 (TpDTMFPlayer)

Summary:	TpDTMFPlayer: dialstring to event-sequence converter
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	tp-glib	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	enhancement
Priority:	medium	CC:	mikhail.zabaluev, pekka.pessi, senko.rasic
Version:	0.13	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/dtmf
Whiteboard:	review+
i915 platform:		i915 features:
Bug Depends on:	30703
Bug Blocks:	28413

Description Simon McVittie 2010-09-30 09:06:50 UTC

For Bug #28413 I wrote GabbleDTMFPlayer, which takes a MultipleTones() dialstring as input, and emits signals started-tone, stopped-tone, finished at appropriate times; these can then be wired up to either MediaSignalling or in-band signalling as appropriate.

Does this look appropriate for at least one of telepathy-sofiasip and telepathy-ring? If so, we should put it in telepathy-glib as general-purpose utility code for CM implementors.

Proposed implementation (with the obvious s/Gabble/Tp/ transformation):

http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=blob;f=src/dtmf.c;h=20fda27979834e873a54a59220f0a28ddac0da3e

http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=blob;f=src/dtmf.h;h=255e6ad8bd82ccdb774369d2ff620004a8d280b6

Comment 1 Simon McVittie 2010-10-22 03:41:10 UTC

The implementation in Gabble has moved on, and now needs more spec too; I'll import it into telepathy-glib when the Gabble prototype in Bug #28413 has been reviewed.

Comment 2 Simon McVittie 2010-10-25 12:33:56 UTC

Here's a real branch.

Comment 3 Jonny Lamb 2010-10-26 03:57:31 UTC

Good (assuming it distchecks).

Comment 4 Simon McVittie 2010-10-26 04:20:41 UTC

Fixed in git for 0.13.3

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.