Bug 30642

Summary:	[PATCH] Convert FASTBOOL to bool everywhere but binfilter
Product:	LibreOffice	Reporter:	Norbert Thiebaud <nthiebaud>
Component:	Libreoffice	Assignee:	Not Assigned <libreoffice-bugs>
Status:	CLOSED FIXED	QA Contact:
Severity:	trivial
Priority:	medium	CC:	gautier.sophie
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	FASTBOOL to bool for base FASTBOOL to bool for calc FASTBOOL to bool for components FASTBOOL to bool for impress Do not use magic number for libs-core FASTBOOL to bool for libs-core FSATBOOL to bool for libs-gui FASTBOOL to bool for writer patch of patches in build for FASTBOOL to bool conversion

Description Norbert Thiebaud 2010-10-06 00:07:41 UTC

These patches remove FASTBOOL everywhere but in binfilter (binfilter
has more FASTBOOL use than the rest of the project combined)

All FASTBOOL are converted into bool, except a couple of API that are
left as int

I made 1 patch per git repo. (For Cedric confort :-) )
There are 2 patches for libs-core. of for straight FASTBOOL to bool
conversion, and one where I removed the use for the FASTBOOL
altogether while tweaking the code to avoid hard-coded array size
constant.

I have compiled them together and vtable-check diff comes back empty.
but It is very doubtful that a  partial apply will work.

the patch build_0001....
is a patch on the patches directory of the build git repo. this one
has NOT been tested.

Comment 1 Norbert Thiebaud 2010-10-06 00:08:46 UTC

Created attachment 39203 [details] [review]
FASTBOOL to bool for base

Comment 2 Norbert Thiebaud 2010-10-06 00:09:28 UTC

Created attachment 39204 [details] [review]
FASTBOOL to bool for calc

Comment 3 Norbert Thiebaud 2010-10-06 00:09:52 UTC

Created attachment 39205 [details] [review]
FASTBOOL to bool for components

Comment 4 Norbert Thiebaud 2010-10-06 00:10:20 UTC

Created attachment 39206 [details] [review]
FASTBOOL to bool for impress

Comment 5 Norbert Thiebaud 2010-10-06 00:11:12 UTC

Created attachment 39207 [details] [review]
Do not use magic number for libs-core

Comment 6 Norbert Thiebaud 2010-10-06 00:11:45 UTC

Created attachment 39208 [details] [review]
FASTBOOL to bool for libs-core

Comment 7 Norbert Thiebaud 2010-10-06 00:12:11 UTC

Created attachment 39209 [details] [review]
FSATBOOL to bool for libs-gui

Comment 8 Norbert Thiebaud 2010-10-06 00:12:46 UTC

Created attachment 39210 [details] [review]
FASTBOOL to bool for writer

Comment 9 Norbert Thiebaud 2010-10-06 00:13:39 UTC

Created attachment 39211 [details] [review]
patch of patches in build for FASTBOOL to bool conversion

Comment 10 Michael Meeks 2010-10-08 06:33:35 UTC

committed - nice work ! thank :-)

Comment 11 sophie 2011-01-13 06:29:01 UTC

Closing - Sophie

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.