Bug 30674

Summary:	Fix USB ID of Sansa Clip+
Product:	media-player-info	Reporter:	Jonathan Ernst <jonathan>
Component:	General	Assignee:	Martin Pitt <martin.pitt>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch fixing the USB Id

Description Jonathan Ernst 2010-10-07 03:29:53 UTC

Disclaimer : I haven't add an occasion to see the actual device

However, while researching informations on the Sans Clip (non-plus edition) and checking the USB ids on http://www.linux-usb.org/usb.ids and various (all concordant) forum posts, the current USB ID in the mpi of Sansa Clip seems to reference the MTP mode and not the Mass storage mode.

The attached patch fixes this.

Comment 1 Jonathan Ernst 2010-10-07 03:30:37 UTC

Created attachment 39252 [details] [review]
Patch fixing the USB Id

Comment 2 Martin Pitt 2010-10-07 03:35:28 UTC

But the current MPI has AccessProtocol=storage. If we'd switch the USB ID to the MTP one, then this would mismatch?

Christophe, you committed that as "Data sent by Jonathan Matthew". Did he actually have that device and test it?

Comment 3 Jonathan Ernst 2010-10-07 03:41:03 UTC

(In reply to comment #2)
> But the current MPI has AccessProtocol=storage. If we'd switch the USB ID to
> the MTP one, then this would mismatch?
> 

74d1 (the one in my patch) is MSC and thus matches AccessProtocol=storage

74d0 (the one currently in git) is MTP and thus doesn't match AccessProtocol=storage (74d0 should be handled by libmtp)

Comment 4 Martin Pitt 2010-10-07 08:06:40 UTC

Thanks, applied.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.