Summary: | Add emacs/vim modelines | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Sebastian@SSpaeth.de <sebastian> |
Component: | Libreoffice | Assignee: | Jan Holesovsky <kendy> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | CC: | gautier.sophie, sebastian |
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
git patch for the "base" repo
Vim/emacs modelines patch for botstrap repository modeline patch for the "calc" repo modeline patch for the "component" repo modelines patch for "extensions" repo modeline patch for "filters" repo modeline patch for "impress" repo modeline patch for "libs-core" repo modeline patch for "libs-gui" repo modeline patch for "sdk" repo modeline patch for "testing" repo modeline patch for "ure" repo modeline patch for "writer" repo all modeline patches for all repos updated modeline patch for ure, libs-gui, writer |
Description
Sebastian@SSpaeth.de
2010-10-12 02:26:05 UTC
Created attachment 39362 [details]
git patch for the "base" repo
Created attachment 39364 [details]
Vim/emacs modelines patch for botstrap repository
Created attachment 39365 [details]
modeline patch for the "calc" repo
Created attachment 39366 [details]
modeline patch for the "component" repo
Created attachment 39367 [details]
modelines patch for "extensions" repo
Created attachment 39368 [details]
modeline patch for "filters" repo
Created attachment 39369 [details]
modeline patch for "impress" repo
Created attachment 39370 [details]
modeline patch for "libs-core" repo
Created attachment 39371 [details]
modeline patch for "libs-gui" repo
Created attachment 39372 [details]
modeline patch for "sdk" repo
Created attachment 39373 [details]
modeline patch for "testing" repo
Created attachment 39374 [details]
modeline patch for "ure" repo
Created attachment 39375 [details]
modeline patch for "writer" repo
With this attachment, all repositories but libs-extern* are finished (I suppose external libs should not be modified).
I did use a clean git checkout and did spot-checks to see if the script really did what it was supposed to do, so I feel pretty confident that it really only does what it's supposed to do.
Just one last comment to clarify. Each attachment is a tar.gz of one patch file that was created with git format-patch and that should be able to simply be fed to "git am" in the respective repos. Let me know if there are difficulties. Created attachment 39383 [details]
all modeline patches for all repos
New diff.tar.gz containing all patches in form:
repo1/0001-Add-vim-emacs-modelines-to-all-source-files.patch
repo2/0001-Add-vim-emacs-modelines-to-all-source-files.patch
The difference is that no empty line follows the initial emacs modeline and that no empty line will inserted before the vim modeline if it already consists of an empty line.
The one thing I did not do is REMOVING multiple empty lines before the last vim modeline if they already had existed.
Pushed everything but libs-gui, ure and writer - the patch failed there, probably needs to be redone against the most recent sources? Can you please attach an update? Thank you! Created attachment 39429 [details]
updated modeline patch for ure, libs-gui, writer
Hi Kendy, here is the updated patch for the 3 remaining repositories All is in the repos now :-) Thank you! Closing - Sophie |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.