| Summary: | Removed tons of comments | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Gil Forcada <gforcada> |
| Component: | Libreoffice | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | medium | CC: | gautier.sophie |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Remove tons of comments
Remove comments, death code and trailing spaces Removed comments, trailing spaces and death code (2) Removed comments, trailing spaces and death code (3) |
||
|
Description
Gil Forcada
2010-10-12 06:58:34 UTC
Created attachment 39384 [details] [review] Remove tons of comments Heh - sooo ... I'm torn on this one. Large automated code-cleanups like this are ok I guess but can create some merge problems.
Also - while I dislike the // ------------- stuff - it is nice to have at least a blank-line separating functions to make them more readable, and there is a good amount of:
}
-// -------------------------------
{
stuff in there :-) any chance of a new line instead ? or was this done manually ?
Thanks.
Oh ! and I forgot to say - thanks for your patch ! :-) it's wonderful to have you contributing, sorry to be slightly nervous this once. Created attachment 39397 [details] [review] Remove comments, death code and trailing spaces Sorry to send such a big patch before, here is a small more well-formed one. It "fixes" the code for base/dbaccess/source/core/api/* files. Created attachment 39398 [details] [review] Removed comments, trailing spaces and death code (2) This patch cleans the base/dbaccess/source/core/dataaccess/*.* files Created attachment 39400 [details] [review] Removed comments, trailing spaces and death code (3) This patch cleans the base/dbaccess/source/core/inc/*.* files Thanks for the patches! I pushed them to the base repo: http://cgit.freedesktop.org/libreoffice/base/commit/?id=2ab6d2bd492320472e33526674923b02876d427d http://cgit.freedesktop.org/libreoffice/base/commit/?id=f061cefaf96f4937b58d0e2ba4fa5bf5187b2d6a http://cgit.freedesktop.org/libreoffice/base/commit/?id=5bf1c6b7723abeaa26260d2b56dbba6359038867 Closing - Sophie |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.