Bug 30915

Summary: [i965 gles2c bisected] OpenGL ES 2.0 conformance GL_functions_input.run/GL_mat_input.run regressed
Product: Mesa Reporter: Shuang He <shuang.he>
Component: Drivers/DRI/i965Assignee: Ian Romanick <idr>
Status: VERIFIED DUPLICATE QA Contact:
Severity: major    
Priority: high CC: chadversary, kenneth
Version: git   
Hardware: Other   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Shuang He 2010-10-15 18:04:19 UTC 
System Environment:
--------------------------
Libdrm:        (master)2.4.22-3-g09b1062628f2cbddb3ebae20e7b3b8a0a93acebf
Mesa:        (master)e2c1fe3eb0fa47f5501b4ec8cd6b732db7ca84be
Xserver:       
(master)xorg-server-1.9.0-131-g23229c7ce5970516b97a1cc12e65257ff65ab9a7
Xf86_video_intel:       
(master)2.12.902-21-g8507ef50ba08061ac158848a7c4c136e1755d87e
Kernel:    (drm-intel-next) 2d7b8366ae4a9ec2183c30e432a4a9a495c82bcd


Bug detailed description:
-------------------------
OpenGL ES 2.0 conformance GL_functions_input.run/GL_mat_input.run regressed  on Piketon. 

bisection shows this regression is due to (And for your reference, this commit fixes 21 OpenGL ES 2.0 conformance test cases on piketon):
commit a81d423d93f22a948f3aa4bf73dc6b1a3b70192f
Author:     Eric Anholt <eric@anholt.net>
AuthorDate: Thu Oct 14 12:23:29 2010 -0700
Commit:     Eric Anholt <eric@anholt.net>
CommitDate: Thu Oct 14 12:40:50 2010 -0700

    i965: Enable the new FS backend on pre-gen6 as well.
    
    It is now to the point where we have no regressing piglit tests.  It
    also fixes Yo Frankie! and Humus DynamicBranching, probably due to the
Comment 1 Ian Romanick 2010-11-17 13:02:19 UTC 
(In reply to comment #0)
> OpenGL ES 2.0 conformance GL_functions_input.run/GL_mat_input.run regressed  on
> Piketon. 

There are 46 tests listed in GL/mat/input.run.  Which tests are failing?
Comment 2 Kenneth Graunke 2010-11-17 15:57:41 UTC 
(In reply to comment #1)
> There are 46 tests listed in GL/mat/input.run.  Which tests are failing?

These three matrix tests fail:
array_const_mat2_frag.test
array_const_mat3_frag.test
array_const_mat4_frag.test
Comment 3 Kenneth Graunke 2010-11-17 16:10:36 UTC 
In GL/functions:

qualifiers_struct_frag.test fails with:
brw_fs.cpp:1385: void fs_visitor::emit_bool_to_cond_code(ir_rvalue*): Assertion `expr->operands[i]->type->is_scalar()' failed.

Also, the following GL/functions tests produce incorrect results;
mat4_empty_empty_mat4_empty_frag.test
mat4_empty_in_mat4_empty_frag.test
mat4_empty_inout_mat4_array_frag.test
mat4_empty_inout_mat4_empty_frag.test
Comment 4 Ian Romanick 2010-12-07 15:37:44 UTC 
(In reply to comment #2)
> (In reply to comment #1)
> > There are 46 tests listed in GL/mat/input.run.  Which tests are failing?
> 
> These three matrix tests fail:
> array_const_mat2_frag.test
> array_const_mat3_frag.test
> array_const_mat4_frag.test

Based on the names, I suspect this is the same issue as bug #31986.  I pushed a fix for that bug a few minutes ago, so we should retest.  Please close the bug as a duplicate if the issue is fixed.
Comment 5 Shuang He 2010-12-10 16:54:50 UTC 
(In reply to comment #4)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > There are 46 tests listed in GL/mat/input.run.  Which tests are failing?
> > 
> > These three matrix tests fail:
> > array_const_mat2_frag.test
> > array_const_mat3_frag.test
> > array_const_mat4_frag.test
> 
> Based on the names, I suspect this is the same issue as bug #31986.  I pushed a
> fix for that bug a few minutes ago, so we should retest.  Please close the bug
> as a duplicate if the issue is fixed.

Yes, both 2 cases passed. Thanks

*** This bug has been marked as a duplicate of bug 31986 ***
Comment 6 Shuang He 2010-12-10 16:56:53 UTC 
Verified on piketon against:
Libdrm:         (master)2.4.22-21-g537703fd4805e9cd352965fce642670986822d22
Mesa:           (master)d5810efca69d016eddd6ece4cb399394c46525db
Xserver:                (server-1.9-branch)xorg-server-1.9.2.902
Xf86_video_intel:               (master)2.13.901-25-g9b967807c2d240488a715509649663aac3583532
Kernel: (drm-intel-fixes) 63abf3edaf42d0b9f278df90fe41c7ed4796b6b1

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.