| Summary: | Inclusion of the Philippines "National Keyboard Layout" | ||
|---|---|---|---|
| Product: | xkeyboard-config | Reporter: | JC John Sese Cuneta <jcjohn.sesecuneta> |
| Component: | General | Assignee: | xkb |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | ross |
| Version: | unspecified | Keywords: | NEEDINFO |
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
symbols file
information needed for .lst and .xml files symbols file (correct file) XKB files edited with PH included Patch files for base.lst, base.xml, evdev.lst, and evdev.xml |
||
Created attachment 39661 [details]
information needed for .lst and .xml files
Created attachment 39746 [details]
symbols file (correct file)
Created attachment 40131 [details]
XKB files edited with PH included
After releasing it to the public, new comments were received. This is the latest version out of it and received zero additional changes and negative feedbacks.
Thanks for the contribution. A couple of notes. symbols/ph file is generally ok. The rules subdirectory is not what I'd expect. Could you please provide the small patch to base.xml.in file? Created attachment 40232 [details]
Patch files for base.lst, base.xml, evdev.lst, and evdev.xml
(In reply to comment #4) > Thanks for the contribution. A couple of notes. symbols/ph file is generally > ok. The rules subdirectory is not what I'd expect. Could you please provide the > small patch to base.xml.in file? Hi, Thanks. Uploaded a the patch files, I hope I did it correctly, something new to learn. ~ JC Committed, thanks. Even though it is strange to see variants consisting mostly of VoidSymbols (In reply to comment #7) > Committed, thanks. Even though it is strange to see variants consisting mostly > of VoidSymbols Hi, thank you very much. Yes, I would agree. The Baybayin script is alphasyllabry so it is always CV-CV, then other vowels are represented by use of a diacritical mark resulting to just 18 base "glyphs" only. Initially I did not include "VoidSymbols" but I noticed that if it is left empty, the system checks the next "upper" keyboard in the list and producing the character there first. 1: Latin = Key1234 produces "A" 2: Baybayin = Key1234 is empty If pressing Key1234 in Baybayin will produce the letter "A" from the Latin layout. I opted instead to hardcode "VoidSymbols" to avoid it. From what I understand, it was intentional? Anyway, I guess that's for another thread / ticket. Thank you again! One question. How would you estimate the number of users for colemak variants? I would be inclined to move them to "extras" section (base.extras.xml.in) This is licensed under GPLv3, instead of MIT as the rest of the layouts. Can this please be changed? (In reply to Daniel Stone from comment #10) > This is licensed under GPLv3, instead of MIT as the rest of the layouts. Can > this please be changed? Removed the GPLv3 line. Hope it is ok with everybody. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 39660 [details] symbols file A request for the inclusion of the new Philippines National Keyboard Layout. The attached file contains the symbols / mapping, and the information needed for the .lst and .xml files. Thank you very much.