Summary: | Line spacing too large for TrueType fonts | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | xorg | Reporter: | Tobias Kunstmann <t.kunstmann> | ||||||||
Component: | Build/Monolithic | Assignee: | Xorg Project Team <xorg-team> | ||||||||
Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||||||
Severity: | normal | ||||||||||
Priority: | high | CC: | cyamauch, cyamauch, jeremyhu, mimsyboro, roland.mainz | ||||||||
Version: | 6.8.2 | ||||||||||
Hardware: | x86 (IA32) | ||||||||||
OS: | All | ||||||||||
Whiteboard: | |||||||||||
i915 platform: | i915 features: | ||||||||||
Attachments: |
|
Description
Tobias Kunstmann
2005-04-24 06:34:42 UTC
Created attachment 2527 [details] [review] Compute line spacing using ascender and descender instead of max height and depth Comment on attachment 2527 [details] [review] Compute line spacing using ascender and descender instead of max height and depth chisato: Can you take a look at the patch and check whether it's OK for you, please ? Created attachment 2533 [details] [review] Patch1 1st patch for testing. Created attachment 2534 [details] [review] Patch2 2nd patch for testing. Roland, thank you for your patch. But, the following code may break a consistency. + yMin = descent = -smetrics->descender / 64; + yMax = ascent = smetrics->ascender / 64; I have attached two patches, would you test them? And please report which patch is required for the bug(or both are needed)? Please pay attention to the old bug: http://bugs.xfree86.org/show_bug.cgi?id=1163 Sorry about the phenomenal bug spam, guys. Adding xorg-team@ to the QA contact so bugs don't get lost in future. This looks like it's fixed in current libXfont. Please reopen if I am mistaken. I write additional infomation. TTCap "fp" might be helpful for problems caused by some application programs (e.g., Web browser). In fonts.dir, you can set it like this: fp=n:foo_times.ttf -foo-times-... where "fp=n" disables FontProperfies such as FONT_ASCENT, FONT_DESCENT, etc. Code for this function is found in ftfuncs.c: if ( font_properties ) { info->props[i].name = MakeAtom("FONT_ASCENT", 11, TRUE); info->props[i].value = info->fontAscent; i++; } : : if ( font_properties ) { info->props[i].name = MakeAtom("FONT_DESCENT", 12, TRUE); info->props[i].value = info->fontDescent; i++; } Default is "fp=y". |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.