Bug 31545

Summary:	[PATCH] uim-chewing: Commit remaining composition before deactivate
Product:	UIM	Reporter:	Kan-Ru Chen <kanru>
Component:	IM: Other IMs	Assignee:	uim-bugs
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	0001-commit-remaining-input-before-deactive.patch

Description Kan-Ru Chen 2010-11-11 00:13:51 UTC

Created attachment 40199 [details] [review]
0001-commit-remaining-input-before-deactive.patch

Hi,

I'm the chewing upstream now playing with uim-chewing.

The normal behavior of chewing is to commit remaining composition before change to direct mode.  I'm quite used to this behavior. So...

The patch attached implements this behavior. ;-)

Regards,
Kanru

Comment 1 Etsushi Kato 2010-11-11 05:05:52 UTC

Thank for playing around with uim-chewing :)  The patch is now committed in uim-chewing-trunk.

And it would be great if you let me know any other glitch you find about uim-chewing as I'm not sure how chewing input should be ;)  Actually, it was my toy project several years ago.

Anyway, thanks again for your patch!

Comment 2 Kan-Ru Chen 2010-11-11 08:16:15 UTC

Thanks!

I love the design philosophy of UIM and want to use it as my day-to-day input method but failed several years ago due to my limited knowledge.

Now I feel for confident and I will try to push uim-chewing to a maturer state :)

Comment 3 Etsushi Kato 2010-11-11 19:00:42 UTC

(In reply to comment #2)
> Now I feel for confident and I will try to push uim-chewing to a maturer state
> :)

Great!

BTW, I've just modified src/chewing.c to stop using inefficient use of uim_scm_eval_c_string().  As I said before, it was created sometimes ago when libuim was not so sophisticated.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.