Bug 31662

Summary: stop using tp_get_bus() in Idle
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: idleAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: git master   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/smcv/idle-smcv.git;a=shortlog;h=refs/heads/get-bus
i915 platform: i915 features:
Bug Depends on: 30536    
Bug Blocks: 24114    

Description Simon McVittie 2010-11-16 09:02:46 UTC
+++ This bug was initially created as a clone of Bug #24114 +++

tp_get_bus() calls exit(), which is Badâ„¢. We can't remove it til we break ABI, but we can at least deprecate it.

Idle still uses this function; it shouldn't.
Comment 1 Simon McVittie 2010-11-17 09:00:18 UTC
Here's a branch. It depends on my protocol and trivia branches.
Comment 2 Simon McVittie 2010-12-01 03:37:55 UTC
r+ from Jonny on IRC, fixed in git for 0.1.7.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.