Bug 31720

Summary: stop using tp_get_bus() in tpsip
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: rakiaAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium CC: mikhail.zabaluev, pekka.pessi
Version: git masterKeywords: patch
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/smcv/telepathy-sofiasip-smcv.git;a=shortlog;h=refs/heads/get-bus
Whiteboard: review+
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 24114    

Description Simon McVittie 2010-11-18 05:45:14 UTC
+++ This bug was initially created as a clone of Bug #31664 +++

+++ This bug was initially created as a clone of Bug #24114 +++

tp_get_bus() calls exit(), which is Badâ„¢. We can't remove it til we break ABI, but we can at least deprecate it.

telepathy-sofiasip still uses this function; it shouldn't. Branch on the way.
Comment 1 Simon McVittie 2010-11-18 05:47:06 UTC
Here, have a branch.
Comment 2 Mikhail Zabaluev 2010-11-23 05:05:38 UTC
(In reply to comment #1)
> Here, have a branch.

Looks fine.
Comment 3 Simon McVittie 2010-11-23 08:14:01 UTC
Fixed in git for 0.7.0
Comment 4 Mikhail Zabaluev 2011-01-28 15:47:12 UTC
Also backported to telepathy-sofiasip 0.6 and released in 0.6.5.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.