Bug 31723

Summary: use TpBaseChannel for Haze's Text and StreamedMedia channels
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: hazeAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: trivial    
Priority: medium CC: will
Version: git master   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 69431    
Attachments: [1/3] HazeIMChannel: chain up properly in dispose
[2/3] HazeIMChannel: use TpBaseChannel
[3/3] exec-with-log.sh: add HAZE_TEST_BACKTRACE hook

Description Simon McVittie 2010-11-18 05:59:15 UTC
telepathy-glib has had TpBaseChannel since 0.11.14. It'd be good to use it in Haze.

There's not much point in using it for ContactList channels, though - we should use TpBaseContactList to replace those, instead.
Comment 1 Simon McVittie 2013-09-17 17:49:35 UTC
TpMessageMixin makes this mandatory in 1.0, so I'm going to have to implement this.

The good news is that this accounts for a lot of the test failures - Haze is getting close to having its own 0.99.1 snapshot. \o/
Comment 2 Simon McVittie 2013-09-23 16:49:22 UTC
Created attachment 86398 [details] [review]
[1/3] HazeIMChannel: chain up properly in dispose

---

Also for 0.8, this is a genuine bug.
Comment 3 Simon McVittie 2013-09-23 16:49:39 UTC
Created attachment 86399 [details] [review]
[2/3] HazeIMChannel: use TpBaseChannel
Comment 4 Simon McVittie 2013-09-23 16:50:00 UTC
Created attachment 86400 [details] [review]
[3/3] exec-with-log.sh: add HAZE_TEST_BACKTRACE hook

---

Similar to the one in MC.
Comment 5 Guillaume Desmottes 2013-09-24 08:29:01 UTC
Comment on attachment 86398 [details] [review]
[1/3] HazeIMChannel: chain up properly in dispose

Review of attachment 86398 [details] [review]:
-----------------------------------------------------------------

++
Comment 6 Guillaume Desmottes 2013-09-24 08:29:48 UTC
Comment on attachment 86399 [details] [review]
[2/3] HazeIMChannel: use TpBaseChannel

Review of attachment 86399 [details] [review]:
-----------------------------------------------------------------

++
Comment 7 Guillaume Desmottes 2013-09-24 08:30:04 UTC
Comment on attachment 86400 [details] [review]
[3/3] exec-with-log.sh: add HAZE_TEST_BACKTRACE hook

Review of attachment 86400 [details] [review]:
-----------------------------------------------------------------

++
Comment 8 Simon McVittie 2013-09-24 11:10:14 UTC
(In reply to comment #2)
> [1/3] HazeIMChannel: chain up properly in dispose
> 
> ---
> 
> Also for 0.8, this is a genuine bug.

Fixed in git for 0.7.2 (or 0.8.0)
Comment 9 Simon McVittie 2013-09-24 11:14:24 UTC
Everything else fixed in git for 0.9.0.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.