Bug 31895

Summary:	Poppler should't call abort() on error
Product:	poppler	Reporter:	Marek Kasik <mkasik>
Component:	general	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	reproducer

Description Marek Kasik 2010-11-24 06:37:13 UTC

Created attachment 40546 [details]
reproducer

Poppler calls abort() from OBJECT_TYPE_CHECK() and OBJECT_2TYPES_CHECK() if it doesn't get correct type.
The attached PDF makes poppler to crash because there are wrong values in BBox on line 3721. These values are stored as objError but getNum() expects objInt or objReal.
Simple "fix" could be change of these abort() to exit() (but still not optimal).

Marek

This was originally reported downstream here:
https://bugzilla.redhat.com/show_bug.cgi?id=625744

Comment 1 Albert Astals Cid 2010-11-24 11:45:16 UTC

Why exit() would be better than abort()? If you feel like discussing this, please do it in the mailing list and not in a bug.

Anyway i've fixed the code to do the correct thing (check objects are numbers before reading them).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.