Summary: | Win32 installer is not BrOffice branded | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Michael Meeks <michael.meeks> |
Component: | UI | Assignee: | Fridrich Strba <fridrich.strba> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | blocker | ||
Priority: | medium | CC: | gautier.sophie, pmladek, thb, tlillqvist |
Version: | 3.3.0 Beta3 | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Bug Depends on: | |||
Bug Blocks: | 31865 |
Description
Michael Meeks
2010-11-26 08:39:05 UTC
Fridrich, could you please look at it? Note that it is considered as a blocker for 3.3 release. I am digging into this myself now - what a read the NSIS code is ! :-> wow. So ... it seems that the command to be using is SetBrandingImage: !macro BIMAGE IMAGE PARMS Push $0 GetTempFileName $0 File /oname=$0 "${IMAGE}" SetBrandingImage ${PARMS} $0 Delete $0 Pop $0 !macroend and it looks like all of this dynamic goodness is exported to the macro language quite nicely: Section "" ; You can also use the BI_NEXT macro here... MessageBox MB_YESNO "We can change the branding image from within a section too!$\nDo you want me to change it?" IDNO done !insertmacro BIMAGE "${NSISDIR}\Contrib\Graphics\Wizard\nsis.bmp" "" done: WriteUninstaller uninst.exe SectionEnd I suggest that we do a certain amount of in-lining of the (URGH!) awful MUI.nsh -> System.nsh logic; and/or if we can clobber this macro: !macro MUI_HEADERIMAGE_INIT UNINSTALLER to be a tad more clever. Lots more notes on this in build/doc/nsis-broffice.txt - the fun part is trying to wind back the locale detection into the scripting language, so we can create a suitable conditional here :-) Perhaps I'm just doing that wrong; possibly we want a translated filename string that is only translated in portugese brazilian - not sure; worth investigating. http://nsis.sourceforge.net/Detect_User_Locale_INFO(Language,_Country,_LangID...) has some information that could be useful @Michael: Thanks for entering yourself into it and compensating my stupidity :) Progressing reasonably nicely ... but very very slow to do a test iteration: this is Windows after all. I hope to have it done early this afternoon. I've implemented, and merged the artwork branding to the libreoffice-3-3 branch. Unfortunately, the string branding is still not done ;-) So we get BrOffice artwork, and LibreOffice strings. Working on fixing that - but by far the easiest way to test that is to use the product name - though IMHO we should switch to keying from locale name for at least a consistent art/strings product. IMNSHO it is not feasible to have dynamic installer strings depending on binary name. Anyhow - getting there :-) I added a new PRODUCTNAME_BR variable to openoffice.lst - which is where the ulf files get their %PRODUCTNAME substitutions from; It is just a matter now of tweaking the pt_BR translations to use %PRODUCTNAME_BR and we have a translated installer. finally pushed the %PRODUCTNAME_BR patch to l10n/ 's .sdf files; all the tests suggest that it should pop out of the end fully localized ... Closing it, if there is still problem, please reopen. Sophie |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.