Bug 32095

Summary:

__glXDRIbindTexImage and magic value of 16

Product:

xorg

Reporter:

Andriy Gapon <avg>

Component:

Server/General

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

CC:

delian2, jlp.bugs

Version:

unspecified

Keywords:

patch

Hardware:

x86-64 (AMD64)

OS:

FreeBSD

See Also:

https://bugs.kde.org/show_bug.cgi?id=256359

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
patch to increase count of tex offset overrides from 16 to 64	none

Description Andriy Gapon 2010-12-04 03:00:40 UTC

Created attachment 40795 [details] [review]
patch to increase count of tex offset overrides from 16 to 64

After the recent KDE update I've been getting the messages like the following:
__glXDRIbindTexImage: Failed to register texture offset override

Please a KDE bug that I originally filed for this issue:
https://bugs.kde.org/show_bug.cgi?id=256359

Finally, I was able to fix or work around the issue by increasing the magic value of offset override (?) slots from 16 to 64.  I didn't try any intermediate values, so something smaller could have worked.

Not sure how to interpret that, but here is my patch.
Hope that this helps.

Comment 1 Andriy Gapon 2010-12-04 03:01:53 UTC

Apologies if I've made incorrect component assignment, not sure which one I should have picked up.

Comment 2 Julien Cristau 2010-12-04 04:42:31 UTC

Please send the patch for review to xorg-devel@lists.x.org, per http://www.x.org/wiki/Development/Documentation/SubmittingPatches

Comment 3 Andriy Gapon 2010-12-04 05:53:20 UTC

(In reply to comment #2)
> Please send the patch for review to xorg-devel@lists.x.org, per
> http://www.x.org/wiki/Development/Documentation/SubmittingPatches

Well, please note that at this time I am not trying to actually submit this patch - I am reporting the problem and trying to understand if and why this patch is needed.
If the patch is found to be worthy, then I sure will follow the procedure to submit it.

Comment 4 Fredrik Höglund 2010-12-04 09:30:35 UTC

KWin seems to be hitting this limit because of an optimization introduced in a recent version, where it tries to avoid rebinding pixmaps to textures each time it renders them.

Maybe this limit should be higher or even dynamic, but I'm willing to consider this a problem in KWin. I've reverted the commit that introduced the issue.

Comment 5 Michel Dänzer 2010-12-08 09:21:06 UTC

(In reply to comment #4)
> KWin seems to be hitting this limit because of an optimization introduced in a
> recent version, where it tries to avoid rebinding pixmaps to textures each time
> it renders them.

The GLX_EXT_texture_from_pixmap spec states that the GLX implementation may require glXBindTexImageEXT() to be called every time for updates to the pixmap contents to be visible in the OpenGL texture. 

> Maybe this limit should be higher or even dynamic, [...]

That would probably require an overhaul of the DRI1 zero-copy texture-from-pixmap hack.

Comment 6 Michel Dänzer 2010-12-17 01:48:23 UTC

*** Bug 32454 has been marked as a duplicate of this bug. ***

Comment 7 Andriy Gapon 2012-08-29 21:26:31 UTC

Please see Bug 52574 for a description of a crash that results from exceeding the number of tex offset overrides (with r600 driver).

Comment 8 Adam Jackson 2015-05-21 17:01:31 UTC

DRI1 AIGLX was removed a few releases ago, closing.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.