Bug 32205

Summary:	Add ability to watch for message acknowledgement in TpMessageMixin
Product:	Telepathy	Reporter:	Danielle Madeley <danielle>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED WONTFIX	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	git master
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/danni/telepathy-glib.git;a=shortlog;h=refs/heads/messages-ack-32205
Whiteboard:
i915 platform:		i915 features:

Description Danielle Madeley 2010-12-07 17:34:31 UTC

Some protocols require you to acknowledge messages in much the same way Telepathy does.

We can either do this immediately upon message receipt (sad) or wait until the client has acknowledged the message, at which point we know it's been shown to the user.

TpMessageMixin should be extended with another (optional) callback, which allows implementors to watch for message acknowledgements coming from the client, and then relay that acknowledgement over the protocol.

Comment 1 Danielle Madeley 2010-12-07 22:12:12 UTC

http://git.collabora.co.uk/?p=user/danni/telepathy-glib.git;a=shortlog;h=refs/heads/messages-ack-32205

Patch to implement this.

Comment 2 Simon McVittie 2010-12-08 03:19:31 UTC

We already had a bug for this, which we closed as WONTFIX since the CM can also connect to pending-messages-removed (the GObject signal used to implement PendingMessagesRemoved). Does the same reasoning still apply?

Comment 3 Simon McVittie 2010-12-08 03:21:37 UTC

See Bug #23238 for background. Artem and Misha reckoned the signal was enough; if you agree, you could close this as a duplicate.

Comment 4 Danielle Madeley 2010-12-08 04:18:46 UTC

I personally think something that returns the TpMessages is more useful.

Especially when TpMessage becomes a GObject, implementers will be able to attach any useful private data to the message with g_object_set_data() including a message identifier, string or pointer to MyProtoMessageObject.

Comment 5 Will Thompson 2011-07-27 10:37:06 UTC

wjt | danni: your branch on https://bugs.freedesktop.org/show_bug.cgi?id=32205 has vanished; do you agree with simon?
danni | wjt: oh, I guess I can agree with simon, I refactored my code long ago

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.