| Summary: | Heading styles are out of order | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Chris Wilson <notgary> |
| Component: | Writer | Assignee: | Sébastien Le Ray <sebastien-libreoffice> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | medium | CC: | cedric.bosdonnat.ooo, detective.conan.1412, LibreOffice, yfjiang |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | EasyHack target:3.5 | ||
| i915 platform: | i915 features: | ||
| Attachments: |
Add a CompareToNumeric to ByteString & UniString
Add compareToNumeric to OUString & Co Patch to solve issue. Apply #43119 before this |
||
|
Description
Chris Wilson
2010-12-13 18:53:58 UTC
Thanks for reporting the usability enhancement. Hi Cedric, should this be marked as easyhack?:) Thanks! (In reply to comment #1) > Thanks for reporting the usability enhancement. > > Hi Cedric, should this be marked as easyhack?:) Thanks! Indeed, this could be an easy hack. The code responsible for this is located here: http://docs.go-oo.org/sfx2/html/templdlg_8cxx-source.html#l01167 Any taker? I'm gonna try this one... Created attachment 43119 [details] [review] Add a CompareToNumeric to ByteString & UniString Since this feature might be usefull elsewhere, attached is a patch to add CompareToNumeric to UniString & ByteString with its unit tests. I'll wait the review before go on. If it's OK, I've the same kind of patch for rtl classes. BTW code pointed in the first comment is not the right place to fix :) (In reply to comment #4) > Created an attachment (id=43119) [details] > Add a CompareToNumeric to ByteString & UniString > > Since this feature might be usefull elsewhere, attached is a patch to add > CompareToNumeric to UniString & ByteString with its unit tests. > I'll wait the review before go on. If it's OK, I've the same kind of patch for > rtl classes. > BTW code pointed in the first comment is not the right place to fix :) Well... those two types are obsolete and we would like to remove them and use rtl::OUString and rtl::OString instead. I know that they're obsolete but changing all the style handling to use OUString/OString would be too much for this bug I guess, that's why I've another set of patch to add the same feature to O(U)String to come if this one is OK. That way the moving from deprecated classes will be easier. Created attachment 43126 [details] [review] Add compareToNumeric to OUString & Co Same as #43119 but for non-obsolete classes. Awaiting review for final patch for this issue. Created attachment 43158 [details] [review] Patch to solve issue. Apply #43119 before this This patch solves the problem in hierarchical and plain view. Patches pushed to master: http://cgit.freedesktop.org/libreoffice/ure/commit/?id=5cb80049f5a9472260947056a25d89fef31d86b1 http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=5f8990c7ace7ffaf34e887c28f345ccc304d2548 http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=81c8a0bf28107cd880c33efd633806cad61fa4f1 This is still happening in 3.4 (In reply to comment #10) > This is still happening in 3.4 This fix will be in 3.5. I've checked the daily build (2011-09-09) on Windows XP and it works fine. EasyHack tags unification: tags only allowed in Whiteboard to make queries more easy and reliable |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.