Summary: | Creating a search channel on a "" (empty string) server fails without an error | ||
---|---|---|---|
Product: | Telepathy | Reporter: | Emilio Pozuelo Monfort <pochu27> |
Component: | gabble | Assignee: | Telepathy bugs list <telepathy-bugs> |
Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
Severity: | normal | ||
Priority: | medium | CC: | pochu27 |
Version: | git master | Keywords: | patch |
Hardware: | Other | ||
OS: | All | ||
URL: | http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=shortlog;h=refs/heads/32390-contact-search-server-property | ||
Whiteboard: | review+ | ||
i915 platform: | i915 features: |
Description
Emilio Pozuelo Monfort
2010-12-14 07:17:34 UTC
Here's a fix. I believe the client should omit Server entirely rather than setting it to the empty string; but Gabble should also be more tolerant. This branch also deals with clients passing invalid JIDs as the server. Looks good to me, except the first commit, which I can't parse (my Python sucks). If you're confident about it, just go for it. Yes the first commit is confusing to me too. - call_create(q, conn, server=None) - answer_field_query(q, stream, JUD_SERVER) + call_create(q, conn, server=server) + ret, _ = answer_field_query(q, stream, JUD_SERVER) This looks wrong in this context alone and looking at the commit message, but actually am I right in thinking you changed the test and then committed patch-by-patch? I don't think "server" has been set by now and so this code belongs in the top commit, no? If so, then it'd be nice if you just changed "server=server" back to "server=None" so that test at that point doesn't fail (so we don't have broken bisects). But maybe I'm wrong?! Other than that it looks good to me too. (In reply to comment #3) > If so, then it'd be nice if you just changed "server=server" back to > "server=None" so that test at that point doesn't fail (so we don't have broken > bisects). > > But maybe I'm wrong?! Good catch. I've rebased my mistake out of existence. + cs.CONTACT_SEARCH_SERVER: 'this is literally bullshit', I love it. This was merged, and will be fixed in 0.11.7. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.