Bug 32578

Summary: Remove keyring support
Product: Telepathy Reporter: Jonny Lamb <jonny.lamb>
Component: mission-controlAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium CC: alban.crequy, guillaume.desmottes, pachoramos1, stefw
Version: git masterKeywords: patch
Hardware: Other   
OS: All   
Whiteboard: review?
i915 platform: i915 features:
Bug Depends on: 42088    
Bug Blocks:    
Attachments: Remove gnome-keyring support
Remove further remnants of gnome-keyring support

Description Jonny Lamb 2010-12-22 09:10:12 UTC
Once all the CMs have SASL support, we should remove the gnome-keyring code in Mission Control.

We should probably wait a bit before merging this though. Just adding the branch here for any early review if anyone's keen. :-)
Comment 1 Simon McVittie 2011-01-03 04:58:17 UTC
Looks good, although I agree we should wait a bit. Release goal for Telepathy 0.22 (MC 5.8).
Comment 2 Jonny Lamb 2011-04-27 08:20:28 UTC
Current status

butterfly: bug #32445 pending review
gabble: done
haze: done
idle: done 
salut: done
sunshine: not done.

Thanks, Python CMs.
Comment 3 Simon McVittie 2012-07-19 09:50:49 UTC
(In reply to comment #2)
> Current status
> 
> butterfly: bug #32445 pending review

Given that current stable MC automatically migrates Butterfly accounts to Haze, I don't think this is a blocker any more.

> sunshine: not done.

I don't think Sunshine actually works in current Empathy anyway. It might possibly work in kde-telepathy if tp-qt still supports the old ContactList channels.

If I knew that Gadu-Gadu worked in Haze, I'd suggest adding a similar migration step from Sunshine to Haze... but I have no idea whether Gadu-Gadu works in anything.
Comment 4 Guillaume Desmottes 2012-07-19 12:45:44 UTC
Yeah Python CM are not supported any more by Empathy so let's just ignore them.
Comment 5 Javier Jardón 2013-03-05 12:54:05 UTC
Hi, what is the status of this? currently mission-control is the only GNOME module dependin on libgnome-keyring ...
Comment 6 Simon McVittie 2013-03-05 16:22:49 UTC
The current status is that (5.12.3 and) 5.13.x still needed keyring support, to carry out an incomplete migration from MC's area of gnome-keyring to Empathy's; so we didn't want to remove keyring support in the 5.13.x cycle, so that users upgrading from 5.12 to 5.14 will get their old passwords deleted correctly.

While it would be OK to remove gnome-keyring support in 5.15.x, we haven't had enough maintainer bandwidth to even release 5.15.0 yet, so 5.14 remains the recommended version for GNOME 3.8. Hopefully 5.16 can be released alongside GNOME 3.10.

Distributions that desperately want to get rid of libgnome-keyring can build with --disable-gnome-keyring if desired.
Comment 7 Simon McVittie 2013-08-28 14:00:36 UTC
Created attachment 84795 [details] [review]
Remove gnome-keyring support

---

Applies to 5.15.0 (I doubt Jonny's patch would, and it seemed quicker to redo it than to fix conflicts).
Comment 8 Simon McVittie 2013-08-29 14:04:50 UTC
*** Bug 64212 has been marked as a duplicate of this bug. ***
Comment 9 Simon McVittie 2013-08-29 14:07:27 UTC
*** Bug 52051 has been marked as a duplicate of this bug. ***
Comment 10 Marco Barisione 2013-09-05 12:16:21 UTC
Comment on attachment 84795 [details] [review]
Remove gnome-keyring support

Review of attachment 84795 [details] [review]:
-----------------------------------------------------------------

Looks good.
Comment 11 Simon McVittie 2013-09-05 15:15:19 UTC
Created attachment 85263 [details] [review]
Remove further remnants of gnome-keyring support
Comment 12 Guillaume Desmottes 2013-09-10 07:12:18 UTC
Comment on attachment 85263 [details] [review]
Remove further remnants of gnome-keyring support

Review of attachment 85263 [details] [review]:
-----------------------------------------------------------------

++
Comment 13 Simon McVittie 2013-09-10 11:22:50 UTC
Fixed in git for 5.15.1, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.