Bug 32690

Summary: Undraft Protocol.Interface.Addressing
Product: Telepathy Reporter: Eitan Isaacson <eitan.isaacson>
Component: tp-specAssignee: Andre Moreira Magalhaes <andrunko>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: Other   
OS: All   
URL: http://cgit.collabora.com/git/user/andrunko/telepathy-spec.git/log/?h=protocol-addressing
Whiteboard: review+ with minor tweaks
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 32691, 41789    

Description Eitan Isaacson 2010-12-27 16:20:42 UTC
This is a simple interface. I will open equivalent tp-glib and gabble bugs for this.
Comment 1 Simon McVittie 2011-01-03 06:50:04 UTC
> [AddressableURISchemes] should only be used when the connection is offline.
> When it is connected the addressable URI schemes should be retrieved from the
> Requests.RequestableChannelClasses's TargetURIScheme fixed-property instead.

That'll only work if Conn.I.Addressing is undrafted, which it hasn't been yet. Perhaps delete this bit and reinstate it in the Conn.I.Addressing branch, or prefix with "After Conn.I.Addressing.DRAFT becomes stable, ..."?

The Gabble implementation in Bug #32692 looks good enough to unblock undrafting this.
Comment 2 Simon McVittie 2011-11-14 04:50:44 UTC
Revisiting this: Comment #1 (broken cross-reference) still stands, unless I review Conn.I.Addressing (which I'll do in a moment) and decide it's already ready.

For use for Facebook IDs in XMPP (the current motivating use-case), x-facebook-id should be added, with an example (if your JID is "-12345@chat.facebook.com" then your x-facebook-id is "12345").
Comment 3 Simon McVittie 2011-11-14 04:52:59 UTC
(In reply to comment #2)
> For use for Facebook IDs in XMPP (the current motivating use-case),
> x-facebook-id should be added, with an example (if your JID is
> "-12345@chat.facebook.com" then your x-facebook-id is "12345").

Alternatively, if there are Facebook developer docs you can link to (some sort of glossary or "basic concepts" or something), do that.

Is "Facebook ID" or "ID" the terminology that Facebook itself uses (e.g. in app APIs)? If not, the vCard field name should probably change to be more like the terminology that FB uses.
Comment 4 Andre Moreira Magalhaes 2011-11-14 07:51:18 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > For use for Facebook IDs in XMPP (the current motivating use-case),
> > x-facebook-id should be added, with an example (if your JID is
> > "-12345@chat.facebook.com" then your x-facebook-id is "12345").
> 
> Alternatively, if there are Facebook developer docs you can link to (some sort
> of glossary or "basic concepts" or something), do that.
There is http://developers.facebook.com/docs/chat/, but I guess it's better to not link it as it may confuse more than help.

> Is "Facebook ID" or "ID" the terminology that Facebook itself uses (e.g. in app
> APIs)? If not, the vCard field name should probably change to be more like the
> terminology that FB uses.
They refer to facebook ID several times in the link above, so I guess we are fine in using this.

Branch updated with x-facebook-id added to the list of known vcard fields. URL updated.
Comment 5 Simon McVittie 2011-11-14 07:58:22 UTC
Ship it, assuming the broken link in Comment #1 doesn't break the build. Conn.I.Addressing will catch up soon enough...
Comment 6 Andre Moreira Magalhaes 2011-11-21 06:43:59 UTC
(In reply to comment #5)
> Ship it, assuming the broken link in Comment #1 doesn't break the build.
> Conn.I.Addressing will catch up soon enough...

Changes merged upstream. I removed the broken link in Comment #1 on patch a9e7212 that should be reverted once Chan.I.Addressing is undrafted. Comment added to bug #42918.
Comment 7 Andre Moreira Magalhaes 2011-11-21 06:44:54 UTC
Marking as fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.