Summary: | Calling without number returns org.freedesktop.Telepathy.Error.NotImplemented | ||
---|---|---|---|
Product: | Telepathy | Reporter: | Andres Wigell <andres.wigell> |
Component: | ring | Assignee: | Pekka Pessi <pekka.pessi> |
Status: | VERIFIED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
Severity: | minor | ||
Priority: | medium | ||
Version: | git master | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: |
Description
Andres Wigell
2010-12-29 04:48:00 UTC
When you say "without number", what exact channel request are you making? In particular, what values (if any) do you provide for TargetID, TargetHandle, TargetHandleType? I think it's reasonable for some combinations to raise NotImplemented: for instance, it'd be reasonable to believe that TargetHandleType=None (or omitted) is an attempt to "call nobody", which is an unimplemented class of channel (we only support calling contacts), hence NotImplemented is right. InvalidHandle would be right for a request for { ChannelType=StreamedMedia, TargetHandleType=CONTACT, TargetID="" }, though. (In reply to comment #1) > When you say "without number", what exact channel request are you making? In > particular, what values (if any) do you provide for TargetID, TargetHandle, > TargetHandleType? > > I think it's reasonable for some combinations to raise NotImplemented: for > instance, it'd be reasonable to believe that TargetHandleType=None (or omitted) > is an attempt to "call nobody", which is an unimplemented class of channel (we > only support calling contacts), hence NotImplemented is right. > > InvalidHandle would be right for a request for { ChannelType=StreamedMedia, > TargetHandleType=CONTACT, TargetID="" }, though. I'm providing empty string so the parameters look like this. So all other parameters are correct apart from the TargetID. request = { ofTChannel + ".ChannelType" : ofTChTStreamedMedia, ofTChannel + ".TargetHandleType" : U(HANDLE_TYPE_CONTACT), ofTChannel + ".TargetID" : "", ofTChTStreamedMedia + ".InitialAudio" : True, } What this is supposed to achieve? InitialAudio is TRUE, so it is supposed to make a call immediately... to where? The interface specification states this for error codes. So according to that we should get Invalid Handle. I know, it's not really a big issue, but the application using the interface might expect different behaviour. # Not Implemented The channel request was one that can never succeed, such as requesting an unsupported channel type, or requesting a channel type which this connection manager does not support with the given target handle type. # Invalid Handle An invalid handle was requested as the value of a property whose value is a handle (like Channel.TargetHandle), or a syntactically invalid identifier was requested as the value of a property whose value is the string corresponding to a handle (like Channel.TargetID). With my telepathy-spec editor hat on, I think Andres is right to expect InvalidHandle here, although it's not very important. OK, now I dig it. InvalidHandle you get. Fix is in git / 2.1.1. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.