| Summary: | Xephyr segfaults on 24bpp hosts | ||
|---|---|---|---|
| Product: | xorg | Reporter: | Michael Stone <michael> |
| Component: | Server/DDX/Xephyr | Assignee: | Matthew Allum <mallum> |
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> |
| Severity: | normal | ||
| Priority: | medium | CC: | ayers, hramrach, jeremyhu |
| Version: | git | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| See Also: |
https://launchpad.net/bugs/635523 https://bugzilla.redhat.com/show_bug.cgi?id=518960 https://qa.mandriva.com/show_bug.cgi?id=47928 https://bugs.freedesktop.org/show_bug.cgi?id=11053 |
||
| Whiteboard: | 2012BRB_Reviewed | ||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 44202 | ||
|
Description
Michael Stone
2010-12-31 17:34:24 UTC
Still seeing this bug in Ubuntu 11.04 (Natty, not Maverick). The definition of the KdScreenInfo data structure changed between the time of the aforementioned patch and now, so the lines: screen->fb[0].depth screen->fb[0].bitsPerPixel should be: screen->fb.depth screen->fb.bitsPerPixel I believe Keith Packard wanted a more robust patch, with the settings being obtained from the underlying XImage. But my individual need is smaller, and Xephyr is segfaulting for me, so the patch is "good enough for me". I applied the patch (with the modifications I mentioned) and Xephyr is now launching properly. I think we should just remove Xephyr in 1.12 now that we have xf86-video-nested On Sun, Sep 18, 2011 at 01:18:20 -0700, bugzilla-daemon@freedesktop.org wrote: > --- Comment #2 from Jeremy Huddleston <jeremyhu@freedesktop.org> 2011-09-18 01:18:18 PDT --- > I think we should just remove Xephyr in 1.12 now that we have xf86-video-nested That seems rather premature to me. Why not? We've been talking about it for 3-4 years now. How long does something need to be unmaintained and bitrot before you decide to move on to its replacement? Has xf86-video-nested been packaged and backported to the stable/LTS releases of the major distributions? If not I would agree that closing this issue is premature. xf86-video-nested is not in the LTS distros, but neither is xserver-1.12. I'm simply advocating that for 1.12 and onward, we should not advocate use of Xnest, Xvfb, Xfake, and Xephyr and instead advocate use of this alternative. This will allow us to not split our efforts across three products which do the exact same thing going forward. If you want to officially deprecate it in 1.12 and remove it in 1.13, I'm happy with that as well. commit 97cf53cc2ad7ecfdd495133bad31d0ec7d939326 Author: Søren Sandmann Pedersen <ssp@redhat.com> Date: Mon Oct 21 16:58:54 2013 -0400 ephyr: hostx_screen_init(): Fix bits_per_pixel and bytes_per_line When the depth of the Xephyr server matches that of the host X server, Xephyr simply uses the buffer associated with the XImage as its framebuffer. In this case, it is correct to get the bits_per_pixel and bytes_per_line values returned from hostx_screen_init() from the XImage. However, when the depth doesn't match the host, Xephyr uses a private framebuffer that is periodically copied to the XImage. In this case, the returned values of bits_per_pixel and bytes_per_line should be those of the private framebuffer, not those of the XImage. Reviewed-by: Eric Anholt <eric@anholt.net> Signed-off-by: Soren Sandmann <ssp@redhat.com> Reviewed-by: Adam Jackson <ajax@redhat.com> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.