| Summary: | "Mail Merge > Send via mail" uses mailaddress from first record for all records | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Cor Nouws <cno> |
| Component: | Libreoffice | Assignee: | Caolán McNamara <caolanm> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | critical | ||
| Priority: | medium | CC: | caolanm, gautier.sophie, libreoffice, michael.meeks |
| Version: | 3.3.0 RC1 | Keywords: | regression |
| Hardware: | x86 (IA32) | ||
| OS: | Linux (All) | ||
| Whiteboard: | target:3.3 | ||
| i915 platform: | i915 features: | ||
| Attachments: |
odb to register and fill with some mail addresses of your own/friends
document with fields very trivial patch to fix this |
||
|
Description
Cor Nouws
2011-01-03 01:10:03 UTC
Cor: Can you please attach an example document to ease the debugging? Thank you! Hi Kendy, Well, I can provide a simple .odb, that you need to register, add you own mail-addresses.. Of course plus an .odt with some fields dragged from the datasource window... But I expect that it is just as easy if you have sour own little test-DB already hanging around? (BTW, this bug caused 430 different document to be send to one mailbox :-\ ..That person will never speak to me again, probably ;-) ) Created attachment 41744 [details]
odb to register and fill with some mail addresses of your own/friends
Created attachment 41745 [details]
document with fields
Hi,
Just installed rc2.
The problem is still there.
Simple .odb and .odt for reproducing attached.
Will add this one on the stopper issue
Kohei - any chance this is some trivial thinko ? Cor - if not, I think we need to punt this to 3.3.1. (In reply to comment #5) > Kohei - any chance this is some trivial thinko ? It is not a problem in the mailmerge.py from Caolan. Tested with that file from OOo installation. It works OK in OOo330rc8, so is a problem in LibO code. > Cor - if not, I think we need to punt this to 3.3.1. Do we have a good way to warn users: do not use this software to mail-merge your relatives ? (Imagine, Jeannet reading my mails for Sophie, Christine, Marijke ... ;-) ) I have no prior experience with this feature, so it'll take some time for me to dig in. With 3.3 just around the corner (or so I hear), I'm not sure if we have any time left to do anything for this... (In reply to comment #7) > I have no prior experience with this feature, so it'll take some time for me to > dig in. With 3.3 just around the corner (or so I hear), I'm not sure if we > have any time left to do anything for this... I understand the situation, but as explained before, I expect serious problems if people use this feature while the bug is there. Ah, I found it. Someone accidentally removed the line that would move to the next record during mail merge as part of a code cleanup. It's a trivial fix. I'll attach a patch shortly for review. Created attachment 41779 [details] [review] very trivial patch to fix this This patch will bring the code back to before the unintended change was introduced. Thanks Kohei :-) Looks good, reviewed and pushed. Ah, nice catch. At first I thought I had caused the bug but looking more closely at git history I see it wasn't me;) But it could as well have been me. Lesson learned: Don't initialise a variable with a *very* side-effectful function call if that variable is then going to be used only in an assertion or other debugging statement. It makes it likely that somebody might later accidentally put also the function call inside an ifdef, thinking that the variable is unused in a non-debugging compilation. nice work Kohei ! :-) thanks ... Verified in RC3 - Closed - Sophie |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.