| Summary: | LibreOffice RC3 doesn't find db 5.1.19 | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Bernhard Rosenkraenzer <bero> |
| Component: | Libreoffice | Assignee: | Petr Mladek <pmladek> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | robert |
| Version: | 3.3.0 RC3 | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
fix (by reverting to RC2 method of checking for db)
db check diff combined solution for libreoffice-3-3 branch |
||
Robert, we really need to improve the check for BerkleyDB. Do you have any idea? Some variant of this may work... http://www.gnu.org/software/autoconf-archive/ax_path_bdb.html Created attachment 42272 [details]
db check diff
(In reply to comment #1) > Robert, we really need to improve the check for BerkleyDB. Do you have any > idea? Hi I think if we want to do the least changes now then we should just check for both functions, later we can use one of the macros. I am not totally happy with the diff I attached but that will work in both cases. Created attachment 42286 [details] [review] combined solution for libreoffice-3-3 branch Unfortunately, Gökçen Eraslan <gokcen@pardus.org.tr> only has the symbols __db185_open_4008 and db_create_4008, so the check for db_create and dbopen is not enough. Also I think that the Another problem is that I did a mistake and committed the older proposed fix to the libreoffice-3-3 branch as http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?h=libreoffice-3-3&id=7a5b94f877de62eb9cd46954ba3a67e465625003 It seems that the commit did not help Gökçen and it broke the check for Bernhard. I am really sorry for this. I will follow the rules for commit into stable branches next time. I am afraid that it is too late to fix this for LO-3.3.0. Though, I would like to fix it for the LO-3.3.1 release. Could you please try the attached patch that checks for even more symbols? The idea is: + keep check for "dbopen" and "__db185_open" to keep backward compatibility with 3.3.0 release + add check for "db_create" that seems to work for most people + add check for "db_create_4008", "db_create_4007", "db_create_4004" that should work for db.h using macros; the version numbers 4008, 4007, 4004 come from the used directory suffixes 4.8, 4.7, 4.4; I have seen these problems with macros only with the 4.x version + do not use AC_CHECK_FUNC; IMHO, it just duplicate the AC_CHECK_LIB and is not really necessary; I did not want to duplicate the long lists of fallbacks. It works here. Also really try the fallback when needed, ... I am going to send this to the mailing list to get approval for the libreoffice-3-3 branch. Could you please verify that it works for you? ping ... Sorry for interrupting, but while working with other "find" issues, I see this one and the latest comment (2011-01-21): Could you please verify that it works for you? I am sorry. I havn't had time to work on this bug yet. It should be better with LO-3.4.0 because it reduces usage of the .rdb files. It replaces it with xml files. Closing for now; this is rather an old problem & putative fix untouched for a year. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 42145 [details] fix (by reverting to RC2 method of checking for db) LibreOffice RC3 doesn't detect a db 5.1.19 installation anymore, claiming db isn't installed. RC2 and earlier work fine. The difference is that RC3 checks for dbopen() while the earlier (working) builds checked for db_create(). Reverting the change fixes the problem.