Bug 33390

Summary:	sm.pc: don't export a dependency on ice
Product:	xorg	Reporter:	Robert Ancell <robert.ancell>
Component:	Lib/other	Assignee:	Xorg Project Team <xorg-team>
Status:	RESOLVED FIXED	QA Contact:	Xorg Project Team <xorg-team>
Severity:	normal
Priority:	medium
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Robert Ancell 2011-01-23 17:51:08 UTC

In git master for libSM ICE is a dependant library:
Requires: ice xproto
However, libICE is not required to use libSM so this can cause your application to be unnecessarily linked to libICE.  For this reason this should be:
Requires.private: ice xproto

Debian (and by extension Ubuntu) has been carrying this July 2008 (2:1.1.0-1) and patches on all the applications that use libSM and libICE since the DSO linking change.

I talked to Julien Cristau (author of the patch and applier in Debian) about this and why it's not upstream and he said:

"fedora has a history of patching their pkg-config and making it not
work, which is why I haven't applied this upstream."

If this patch is correct (as it appears to be) and it works with the upstream pkg-config could it please be applied to master?  The current situation makes Debian based systems carry a lot of patches and a lot of work to get non-Debian based upstreams to take these patches.

Comment 1 Alan Coopersmith 2011-02-01 20:02:44 UTC

Fix reviewed on xorg-devel, no one complained, so it's pushed to git master:
http://cgit.freedesktop.org/xorg/lib/libSM/commit/?id=b29f5c9f3a728c5b7673cf54ad60d988b5dd93e7

We'll see if any tinderboxes break or anyone building from git hits issues.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.