Bug 33449

Created attachment 42434 [details]
The dmesg about screen white

Do the patches in #33324 fix this?  What's the stderr output from compiz?

Whole Screen white still exist,when testing in commit (master)be3be7580b6f6fd2f7fa4d4abfe5e1ab19470223 with two patches(id=42338,id=42339)you given in #33324. Only in dmesg: end_request: I/O error, dev fd0, sector 0

> --- Comment #3 from meng <mengmeng.meng@intel.com> 2011-01-25 21:25:46 PST ---
> Whole Screen white still exist,when testing in commit
> (master)be3be7580b6f6fd2f7fa4d4abfe5e1ab19470223 with two
> patches(id=42338,id=42339)you given in #33324. Only in dmesg: end_request: I/O
> error, dev fd0, sector 0
> 
You didn't answer my other question.  What's the output from compiz?

step:
1.gnome-session
2.enable compiz
output from compiz:
compiz[2926]: segfault at 329862ea80 ip 000000329862ea80 sp 00007fffe8cc4058 error 14 in libXxf86vm.so.1.0.0[329b400000+5000]

It's backtrace:
(gdb) bt
#0  0x0000003288ed4d78 in poll () from /lib64/libc.so.6
#1  0x000000000040ed49 in ?? ()
#2  0x0000000000411517 in eventLoop ()
#3  0x000000000040bc4b in main ()

> --- Comment #5 from meng <mengmeng.meng@intel.com> 2011-01-26 00:35:56 PST ---
> output from compiz:
> compiz[2926]: segfault at 329862ea80 ip 000000329862ea80 sp 00007fffe8cc4058
> error 14 in libXxf86vm.so.1.0.0[329b400000+5000]

That's not output from compiz, that's your kernel log.  I'm not
interested in your kernel log, I'm interested in knowing what request
gets an error from the X server.  Which might (or might not) be in
compiz's stderr, but certainly won't be in dmesg.

I'm sorry I don't know how to get the compiz's stderr.Could you tell me that?

Using gnome-session, the stderr should be captured in ~/.xsession-errors

Created attachment 42518 [details] [review]
fix BindTexImage length check

This should hopefully make compiz work...

In your patch(id=42518),
-    REQUEST_FIXED_SIZE(xGLXVendorPrivateReq, 8);
+    REQUEST_AT_LEAST_SIZE(xGLXVendorPrivateReq, 12);
Maybe there is a mistype in your patch which caused it failed to compile. I guess maybe you meant as following:
-    REQUEST_FIXED_SIZE(xGLXVendorPrivateReq, 8);
+    REQUEST_FIXED_SIZE(xGLXVendorPrivateReq, 12);

After we applied the new patch, it works fine. I tested with xserver(master)be3be7580b6f6fd2f7fa4d4abfe5e1ab19470223 with above patch.

On Wed, Jan 26, 2011 at 19:54:06 -0800, bugzilla-daemon@freedesktop.org wrote:

> https://bugs.freedesktop.org/show_bug.cgi?id=33449
> 
> --- Comment #11 from meng <mengmeng.meng@intel.com> 2011-01-26 19:54:06 PST ---
> In your patch(id=42518),
> -    REQUEST_FIXED_SIZE(xGLXVendorPrivateReq, 8);
> +    REQUEST_AT_LEAST_SIZE(xGLXVendorPrivateReq, 12);
> Maybe there is a mistype in your patch which caused it failed to compile. I
> guess maybe you meant as following:
> -    REQUEST_FIXED_SIZE(xGLXVendorPrivateReq, 8);
> +    REQUEST_FIXED_SIZE(xGLXVendorPrivateReq, 12);
> 
oops, sorry about that.  I think that should be
+    if ((sizeof(xGLXVendorPrivateReq) + 12) >> 2 > client->req_len)
+       return BadLength;

thanks!

As Julien pointed out, this implies we are doing our compiz QA via indirect rendering? Do we also check direct rendering + compiz?

Tested with xserver(master)ea1ffd3e60bdcedbec5a6f28929f8677bf45d450 with apatch,it works fine.
------------------------------------------------------------------
-    REQUEST_FIXED_SIZE(xGLXVendorPrivateReq, 8);
+    if ((sizeof(xGLXVendorPrivateReq) + 12) >> 2 > client->req_len)
+    return BadLength;

(In reply to comment #13)
> As Julien pointed out, this implies we are doing our compiz QA via indirect
> rendering? Do we also check direct rendering + compiz?

glxinfo | grep "direct rendering"
direct rendering: Yes
Then,compiz use no direct rendering:lsof | grep id(compiz)|grep dri
Can you tell me how to let Compiz work with "direct rendering"?

Compiz is indirect rendering when this Piketon'system is in Fedora 11. But other in Fedora 13,compiz is direct rendering.

Fixed in 1.10 rc2, thanks for the report.

Verified with Xserver:(master)b4ef34d4664e0eaac7211f7a22a2025958aa1527.