Bug 33706

Summary:	Fix minor typos
Product:	poppler	Reporter:	Rafał Mużyło <galtgendo>
Component:	general	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Rafał Mużyło 2011-01-29 20:04:10 UTC

1. similar as in a recent evince bug NULL!=0, so in poppler/CurlCachedFile.cc
at line 41: 'long code = NULL;' is incorrect
2. cosmetic (as it's just in test/pdf-inspector.ui) but IIRC GtkAdjustement with page_size != 0 for GtkSpinButton triggers deprecation warnings in any decently recent gtk+


Finally, a minor nitpick about 0.16.2 tarball: I don't see test/tests or test/unittestcases in the git nor are they mentioned in test/CMakeFiles.txt,test/Makefile.am- added accidentally ?

Comment 1 Albert Astals Cid 2011-01-30 03:47:46 UTC

"Finally, a minor nitpick about 0.16.2 tarball: I don't see test/tests or
test/unittestcases in the git nor are they mentioned in
test/CMakeFiles.txt,test/Makefile.am- added accidentally ?"

http://cgit.freedesktop.org/poppler/test

Comment 2 Albert Astals Cid 2011-01-30 03:48:49 UTC

Please, report one bug per each non related issue, not three issues in one bug.

Comment 3 Rafał Mużyło 2011-03-03 14:22:39 UTC

Well, as 0.16.3 tarball is without tests (as pre 0.16.2 were), let's say this bug focuses on 0!=NULL part - tests are secondary anyway.

Comment 4 Albert Astals Cid 2011-03-03 14:28:41 UTC

I don't see any attachment fixing the typos

Comment 5 Rafał Mużyło 2011-03-03 14:43:15 UTC

An attachment ?
For a change from
long code = NULL;
to
long code = 0;

Seriously...

Comment 6 Albert Astals Cid 2011-03-12 05:50:50 UTC

Removed the offending line in master

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.